mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
33,694 Commits 63 Branches 451 Tags 660 MiB
Commit Graph

5 Commits

Author SHA1 Message Date
Kevin Burke 67fcd9c5d9 cmd/internal/browser: fix typo 
Change-Id: I3c31f10c1082c7bc57aac18856014c55f79e0fed
Reviewed-on: https://go-review.googlesource.com/37409
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
 2017-02-24 20:49:10 +00:00
Chris Broadfoot 2818cb5c9e cmd/internal/browser: wait 3 seconds for non-zero exit codes 
Wait a short period between trying commands. Many commands
will return a non-zero exit code if the browser couldn't be launched.

For example, google-chrome returns quickly with a non-zero
exit code in a headless environment.

Updates #19131.

Change-Id: I0ae5356dd4447969d9e216615449cead7a8fd5c9
Reviewed-on: https://go-review.googlesource.com/37391
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
 2017-02-24 19:14:12 +00:00
Chris Broadfoot d580972d59 cmd/internal/browser: use xdg-open only from a desktop session 
xdg-open's man page says:
> xdg-open is for use inside a desktop session only.

Use the DISPLAY environment variable to detect this.

Updates #19131.

Change-Id: I3926b3e1042393939b2ec6aacd9b63ac8192df3b
Reviewed-on: https://go-review.googlesource.com/37390
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
 2017-02-23 19:17:15 +00:00
Daniel Martí 241dccc4fd cmd/internal/browser: add chromium to the list of browsers 
Many linux distros distribute Chromium instead of Chrome.

Change-Id: I5474d94da28a7c79bdd7181f77472d4ce73bb225
Reviewed-on: https://go-review.googlesource.com/29293
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
 2016-11-12 00:29:12 +00:00
Josh Bleecher Snyder 33ed356475 cmd: add internal/browser package 
cmd/cover, cmd/trace, and cmd/pprof all open browsers.
'go bug' will soon also open a browser.
It is time to unify the browser-handling code.

Change-Id: Iee6b443e21e938aeaaac366a1aefb1afbc7d9b2c
Reviewed-on: https://go-review.googlesource.com/29160
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
 2016-09-14 18:26:33 +00:00