3 Commits

Author	SHA1	Message	Date
Suzy Mueller	30fbd19e84	internal/lsp: fix fillstruct for structs with unsafe.Pointer ... Provide a default value for unsafe.Pointer in fillstruct. Fixes golang/go#52640 Change-Id: I10a1878fbf53b082f83f44e0ba2788ead14439d6 Reviewed-on: https://go-review.googlesource.com/c/tools/+/403535 TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Suzy Mueller <suzmue@golang.org> gopls-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Robert Findley <rfindley@google.com> Reviewed-by: David Chase <drchase@google.com>	2022-05-05 17:08:12 +00:00
Jean de Klerk	0e8b1ee181	gopls, internal/lsp: support fillstruct for partially-filled structs ... This updates fillstruct to work even when the struct is partially filled. User supplied fields are preserved but comments are blown away. Preserving comments appears to be very hard with the current ast library. One possible option is to do manual string shenanigans, but after exploring that path it seems like A Bad Idea. Fixes golang/go#39804 Change-Id: Iec0bb93db05d4d726dfa6c77a8139f53b14bcc77 Reviewed-on: https://go-review.googlesource.com/c/tools/+/262018 Run-TryBot: Jean de Klerk <deklerk@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org> Trust: Jean de Klerk <deklerk@google.com>	2020-11-30 20:22:45 +00:00
Heschi Kreinick	aeb8e36929	internal/lsp: remove multi-module support in tests ... Mostly a rollback of CL 217541. No changes in the actual tests. Change-Id: I910551d4750822bd2d8c5039d1cf194e42d01500 Reviewed-on: https://go-review.googlesource.com/c/tools/+/256363 Trust: Heschi Kreinick <heschi@google.com> Run-TryBot: Heschi Kreinick <heschi@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Robert Findley <rfindley@google.com>	2020-09-22 16:28:30 +00:00