183edddb9d
gofmt'ed more stragglers
...
(now down to a handfull of files in pkg)
R=rsc
http://go/go-review/1019006
2009-11-05 18:24:24 -08:00
f31bc223b3
fix UTF-8 upload bug
...
TBR=r
http://go/go-review/1026001
2009-11-05 18:23:26 -08:00
0ea9dd815a
gofmt the last outstanding files in src/pkg
...
- added a list of issues to printer/nodes.go
R=rsc
http://go/go-review/1024002
2009-11-05 18:14:47 -08:00
39fd52d3a0
gofmt'ed missing regexp file
...
(one-line functions will be re-established once we have all
formatted uniformly)
R=r
http://go/go-review/1023004
2009-11-05 17:35:40 -08:00
38006946e6
manual fix for better gofmt result
...
R=r
http://go/go-review/1019005
2009-11-05 17:27:02 -08:00
8cd2e76404
- gofmt'ing of some stragglers, now with correct comment indentation
...
in special cases
- re-gofmt'ing of some files that are now improved
R=r, rsc
http://go/go-review/1023003
2009-11-05 17:02:55 -08:00
6c13f8f10e
fix a comment formatting bug:
...
- this ensures better comment formatting in template.go and codec_test.go
- it affects only 2 files of all files that have been gofmt'ed already,
see separate CL (it fixes the same issue in those files)
R=rsc
http://go/go-review/1023002
2009-11-05 17:02:29 -08:00
fa57417dbd
crypto/tls (part 6/5)
...
Results of running gofmt again.
R=rsc
CC=go-dev
http://go/go-review/1022006
2009-11-05 16:59:39 -08:00
e4a6e422b2
fix broken link
...
R=rsc, iant
CC=go-dev
http://go/go-review/1019003
2009-11-05 16:44:55 -08:00
eb48f83ae2
crypto/tls (part 5/5)
...
Make RSA and X509 build by using big. (This involves commenting out
key generation for now since I haven't written Miller-Rabin in big
yet.)
Add entries to the Makefile.
R=rsc
CC=go-dev
http://go/go-review/1022005
2009-11-05 16:44:02 -08:00
950f2637c2
crypto/tls (part 4/5)
...
R=rsc
CC=go-dev
http://go/go-review/1019002
2009-11-05 16:43:29 -08:00
2f1d6a5d91
Cleaned up gccgo error messages require minor adjustment to
...
test.
const1.go:27: error: integer constant overflow
const1.go:29: error: integer constant overflow
const1.go:30: error: integer constant overflow
const1.go:31: error: integer constant overflow
const1.go:32: error: integer constant overflow
const1.go:33: error: integer constant overflow
const1.go:33: error: integer constant overflow
const1.go:34: error: integer constant overflow
const1.go:37: error: integer constant overflow
const1.go:38: error: integer constant overflow
const1.go:40: error: integer constant overflow
const1.go:41: error: integer constant overflow
const1.go:43: error: integer constant overflow
const1.go:44: error: integer constant overflow
const1.go:45: error: integer constant overflow
const1.go:48: error: integer constant overflow
const1.go:50: error: integer constant overflow
const1.go:51: error: integer constant overflow
const1.go:52: error: integer constant overflow
const1.go:53: error: integer constant overflow
const1.go:55: error: integer constant overflow
const1.go:56: error: division by zero
const1.go:59: error: floating point constant overflow
const1.go:61: error: floating point constant overflow
const1.go:62: error: division by zero
const1.go:47: error: integer constant overflow
const1.go:49: error: integer constant overflow
const1.go:60: error: floating point constant overflow
const1.go:68: error: argument 1 has incompatible type (cannot use type int8 as type int)
const1.go:69: error: argument 1 has incompatible type (cannot use type int8 as type int)
const1.go:70: error: argument 1 has incompatible type (cannot use type uint8 as type int)
const1.go:72: error: argument 1 has incompatible type (cannot use type float32 as type int)
const1.go:73: error: argument 1 has incompatible type (cannot use type float as type int)
const1.go:74: error: floating point constant truncated to integer
const1.go:76: error: argument 1 has incompatible type (cannot use type float64 as type int)
const1.go:77: error: argument 1 has incompatible type
const1.go:78: error: argument 1 has incompatible type
R=rsc
http://go/go-review/1022001
2009-11-05 16:04:45 -08:00
10242e806f
gofmt'ed parts of go
...
R=rsc
http://go/go-review/1023001
2009-11-05 15:58:28 -08:00
65063bc61d
big: add Div, Mod, Exp, GcdExt and several other fixes.
...
R=gri, rsc
CC=go-dev
http://go/go-review/1017036
2009-11-05 15:55:41 -08:00
5e598c55dc
crypto/tls (part 3)
...
(With hindsight, record_process might have been designed wrong, but it
works for now. It'll get redrawn when client support is added.)
R=rsc
CC=r
http://go/go-review/1018032
2009-11-05 15:44:32 -08:00
d3d3accdb7
gofmt-ify io, json, runtime, encoding
...
R=rsc
http://go/go-review/1017056
2009-11-05 15:37:55 -08:00
441e775dad
gofmt'ed godefs
...
R=rsc
http://go/go-review/1020001
2009-11-05 15:35:53 -08:00
6a4940ee23
gofmt'ed debug
...
(excluding debug/gosym/symtab.go which has a small issue)
R=rsc
http://go/go-review/1019001
2009-11-05 15:35:02 -08:00
6f762f5410
gofmt'ed 6l 8l cgo
...
R=r
http://go/go-review/1020002
2009-11-05 15:33:26 -08:00
b8d88a9913
gofmt-ify strings, template
...
R=r
http://go/go-review/1018064
2009-11-05 15:12:37 -08:00
5f50a81863
add information comparing the compiler implementations to the installation document
...
R=rsc
CC=go-dev
http://go/go-review/1018063
2009-11-05 15:07:42 -08:00
f65e42d039
gofmt-ify gob
...
(the one-line struct types used in composite literals will become
one line again in another cleanup round; don't worry about them now)
R=r
http://go/go-review/1016056
2009-11-05 14:53:42 -08:00
790c9b59d6
codereview: new commands
...
* clpatch
* download
* submit, on behalf of clpatch
stir hgpatch to fix a few bugs
R=r
CC=go-dev
http://go/go-review/1016051
2009-11-05 14:44:57 -08:00
9786b3f1bd
gofmt-ify 4s, iterable
...
R=rsc
http://go/go-review/1016055
2009-11-05 14:43:03 -08:00
2a89915485
gofmt-ify draw
...
R=rsc
http://go/go-review/1017055
2009-11-05 14:42:28 -08:00
9e48df682c
gofmt-ify eval
...
R=rsc
http://go/go-review/1016054
2009-11-05 14:41:56 -08:00
d2af73136e
gofmt-ify ogle
...
R=rsc
http://go/go-review/1016053
2009-11-05 14:30:18 -08:00
6238964d7b
gofmt-ify nacl
...
R=rsc
http://go/go-review/1018062
2009-11-05 14:29:38 -08:00
77334b988c
gofmt-ify reflect
...
- the single line structs can be fixed in another round
R=rsc
http://go/go-review/1016052
2009-11-05 14:23:20 -08:00
666afa1c02
2nd attempt: no noIndent for string lists
...
- slightly better output in general
- extra indentation where we could do without
(however that seems better for now that not having the indentation
where it is needed)
- no information is lost, so a future better approach can fix these
places up again
R=rsc
http://go/go-review/1017050
2009-11-05 14:03:56 -08:00
f93ecca397
add a place-holder link for the hour-long video
...
R=rsc
CC=go-dev
http://go/go-review/1017054
2009-11-05 13:46:12 -08:00
d5717d262a
update the text on the landing page.
...
R=agl, rsc
CC=go-dev
http://go/go-review/1017053
2009-11-05 13:39:00 -08:00
18cb960f3e
forgot a piece of debugging
...
in previous change
R=rsc
http://go/go-review/1017052
2009-11-05 13:05:07 -08:00
505fd760a2
same speedup as 6l
...
R=rsc
http://go/go-review/1016050
2009-11-05 12:47:22 -08:00
51c1bd229b
godoc: style update.
...
R=r, rsc
CC=go-dev
http://go/go-review/1017051
2009-11-05 12:18:54 -08:00
bd4f94057f
gofmt-ify syscall
...
(replacement for CL 1018053)
R=r
http://go/go-review/1017047
2009-11-05 10:55:57 -08:00
30c7088c95
gofmt-ify template, time, unsafe, flag, fmt
...
(replacement for CLs 1017039, 1017041, 1017040, 1018054)
R=r
http://go/go-review/1018060
2009-11-05 09:40:28 -08:00
1329012a23
new command hgpatch, for use by codereview extension
...
R=r
http://go/go-review/1018059
2009-11-05 09:27:19 -08:00
3630bfbe9f
gofmt-ify math, expvar, exp/spacewar
...
R=rsc
http://go/go-review/1018061
2009-11-05 09:08:08 -08:00
e57acdca4d
gofmt-ify parts of xml
...
R=rsc
http://go/go-review/1017049
2009-11-05 08:59:03 -08:00
12dbd06f0a
gofmt-ify encoding
...
R=rsc
http://go/go-review/1017048
2009-11-05 08:55:18 -08:00
9df7d6ef10
add -l flag to hg gofmt.
...
don't apply gofmt to non-go files during upload check.
R=r
http://go/go-review/1016048
2009-11-05 08:11:44 -08:00
d8e0d9a778
add "hg gofmt" to run all modified files through gofmt.
...
add check before Upload, for now disabled by default,
that files do not change when run through gofmt.
enable by adding
[codereview]
force_gofmt = True
to .hgrc or .hg/hgrc.
add doc strings for a few more commands.
rename codereview-login to code-login
to make module doc visible.
R=r
CC=gri
http://go/go-review/1018056
2009-11-04 23:43:55 -08:00
ed494c6398
gofmt-ify sort, sync
...
R=rsc
http://go/go-review/1018057
2009-11-04 23:25:29 -08:00
314b358ab7
gofmt-ify strconv
...
(and remove an empty line at the end of a file)
R=rsc
http://go/go-review/1017046
2009-11-04 23:20:49 -08:00
5d37705416
gofmt-ify net
...
R=rsc
http://go/go-review/1017045
2009-11-04 23:16:46 -08:00
7df45566db
gofmt-ify image
...
R=rsc
http://go/go-review/1017044
2009-11-04 22:52:28 -08:00
ca2a69ea06
gofmt-ify hash, http
...
(gofmt will be able to re-align map entries as in http nicely,
eventually)
R=rsc
http://go/go-review/1018055
2009-11-04 22:45:59 -08:00
b16e6ab148
gofmt-ify tabwriter
...
R=rsc
http://go/go-review/1017042
2009-11-04 22:26:48 -08:00
1fede304ff
more comment formatting:
...
- preserve (some) indentation of comment text for /*-style comments
even if the first comment line does not contain any text that might
suggest the "correct" indentation
- enabled because otherwise existing larger comments get re-formatted
(this will not introduce a lot of changes since comments of this
kind - until now - were not changed with respect to indentation)
R=rsc
http://go/go-review/1016047
2009-11-04 22:07:13 -08:00
Robert Griesemer
Russ Cox
Adam Langley
Rob Pike
Ian Lance Taylor
Ken Thompson