mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

net: skip tests that use netsh on the windows-arm64-10 builder 

These tests sometimes hang on Windows 10 on ARM64, due to what appears
to be a platform bug. Since we have not yet observed any such hangs on
the windows-arm64-11 builder, I am leaving the tests otherwise enabled
on the theory that the platform bug may have been fixed in Windows 11.

Fixes #52082 (at least for now).

Change-Id: I79161f485b1921f083ebcf01865d6e7b0178ef70
Reviewed-on: https://go-review.googlesource.com/c/go/+/397315
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
This commit is contained in:
Bryan C. Mills 2022-03-31 14:58:20 -04:00 committed by Bryan Mills
parent 434b2a5d0d
commit ff6b6c61d7
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/net/net_windows_test.go
View File

@ -8,6 +8,7 @@ import (
"bufio"
"bytes"
"fmt"
"internal/testenv"
"io"
"os"
"os/exec"
@ -205,6 +206,13 @@ func runCmd(args ...string) ([]byte, error) {
}
func checkNetsh(t *testing.T) {
if testenv.Builder() == "windows-arm64-10" {
// netsh was observed to sometimes hang on this builder.
// We have not observed failures on windows-arm64-11, so for the
// moment we are leaving the test enabled elsewhere on the theory
// that it may have been a platform bug fixed in Windows 11.
testenv.SkipFlaky(t, 52082)
}
out, err := runCmd("netsh", "help")
if err != nil {
t.Fatal(err)