mirror of https://github.com/golang/go.git
runtime/pprof: fix data race
It's unclear why we do this broken double-checked locking. The mutex is not held for the whole duration of CPU profiling. Fixes #8365. LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/116290043
This commit is contained in:
parent
11016f62d8
commit
fe7b29f5fd
|
|
@ -574,12 +574,6 @@ func StartCPUProfile(w io.Writer) error {
|
|||
// each client to specify the frequency, we hard code it.
|
||||
const hz = 100
|
||||
|
||||
// Avoid queueing behind StopCPUProfile.
|
||||
// Could use TryLock instead if we had it.
|
||||
if cpu.profiling {
|
||||
return fmt.Errorf("cpu profiling already in use")
|
||||
}
|
||||
|
||||
cpu.Lock()
|
||||
defer cpu.Unlock()
|
||||
if cpu.done == nil {
|
||||
|
|
|
|||
Loading…
Reference in New Issue