mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[release-branch.go1.18] encoding/xml: skip TestCVE202230633 for short tests 

TestCVE202230633 uses a bunch of memory, and the input cannot be
feasibly reduced while maintaining the behavior hasn't regressed. This
test could be reasonably removed, but I'd rather keep it around if we
can.

Updates #53814.
Fixes #54128.

Change-Id: Ie8b3f306efd20b2d9c0fb73122c26351a55694c4
Reviewed-on: https://go-review.googlesource.com/c/go/+/417655
Run-TryBot: Roland Shoemaker <roland@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
(cherry picked from commit 783ff7dfc4)
Reviewed-on: https://go-review.googlesource.com/c/go/+/421094
Reviewed-by: Cherry Mui <cherryyz@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
This commit is contained in:
Roland Shoemaker 2022-07-14 12:09:19 -07:00 committed by Dmitri Shuralyov
parent be59153dd8
commit fcdd099a96
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/encoding/xml/read_test.go
View File

@ -9,7 +9,6 @@ import (
"errors"
"io"
"reflect"
"runtime"
"strings"
"testing"
"time"
@ -1084,8 +1083,8 @@ func TestUnmarshalWhitespaceAttrs(t *testing.T) {
}
func TestCVE202230633(t *testing.T) {
if runtime.GOARCH == "wasm" {
t.Skip("causes memory exhaustion on js/wasm")
if testing.Short() {
t.Skip("test requires significant memory")
}
defer func() {
p := recover()