From fafc446eff2eef680efc3a31e005235ecf595be3 Mon Sep 17 00:00:00 2001 From: Than McIntosh Date: Mon, 8 Nov 2021 18:21:47 -0500 Subject: [PATCH] go/internal/gccgoimporter: skip obj importer test on AIX Skip the obj importer test when running on AIX. For this test to work properly on AIX, we need to port CL 152720 (or something like it) here from the main repo. Updtes golang/go/#49445. Updates golang/go#29113. Change-Id: If75a452950a5dcad4afa18d973f3c94b6065f724 Reviewed-on: https://go-review.googlesource.com/c/tools/+/362434 Trust: Than McIntosh Run-TryBot: Than McIntosh Reviewed-by: Ian Lance Taylor gopls-CI: kokoro TryBot-Result: Go Bot --- go/internal/gccgoimporter/importer_test.go | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/go/internal/gccgoimporter/importer_test.go b/go/internal/gccgoimporter/importer_test.go index 3a69c0864c..7adffd0df8 100644 --- a/go/internal/gccgoimporter/importer_test.go +++ b/go/internal/gccgoimporter/importer_test.go @@ -14,6 +14,7 @@ import ( "os/exec" "path/filepath" "regexp" + "runtime" "strconv" "testing" ) @@ -132,6 +133,12 @@ func TestObjImporter(t *testing.T) { if gpath == "" { t.Skip("This test needs gccgo") } + if runtime.GOOS == "aix" { + // We don't yet have a debug/xcoff package for reading + // object files on AIX. Remove this skip if/when issue #29038 + // is implemented (see also issue #49445). + t.Skip("no support yet for debug/xcoff") + } verout, err := exec.Command(gpath, "--version").CombinedOutput() if err != nil {