mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

cmd/compile/internal/test: skip testpoint due to revert of CL 479095 

Skip one of the testpoints that verifies inlining, since it
no longer passes as a result of reverting CL 479095. Once we
roll forward with a new version of CL 479095 we can re-enable
this testpoint.

Change-Id: I41f6fb3fce78f31e60c5f0ed2856be0e66865149
Reviewed-on: https://go-review.googlesource.com/c/go/+/481755
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Than McIntosh <thanm@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
This commit is contained in:
Than McIntosh 2023-04-03 14:09:03 -04:00
parent ccad8a9f9c
commit f46320849d
1 changed files with 13 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/cmd/compile/internal/test/inl_test.go
View File

@ -180,15 +180,19 @@ func TestIntendedInlining(t *testing.T) {
"net": { "net": {
"(*UDPConn).ReadFromUDP", "(*UDPConn).ReadFromUDP",
}, },
"sync": { // These testpoints commented out for now, since CL 479095
// Both OnceFunc and its returned closure need to be inlinable so // had to be reverted. We can re-enable this once we roll
// that the returned closure can be inlined into the caller of OnceFunc. // forward with a new version of 479095.
"OnceFunc", /*
"OnceFunc.func2", // The returned closure. "sync": {
// TODO(austin): It would be good to check OnceValue and OnceValues, // Both OnceFunc and its returned closure need to be inlinable so
// too, but currently they aren't reported because they have type // that the returned closure can be inlined into the caller of OnceFunc.
// parameters and aren't instantiated in sync. "OnceFunc",
}, "OnceFunc.func2", // The returned closure.
// TODO(austin): It would be good to check OnceValue and OnceValues,
// too, but currently they aren't reported because they have type
// parameters and aren't instantiated in sync.
}, */
"sync/atomic": { "sync/atomic": {
// (*Bool).CompareAndSwap handled below. // (*Bool).CompareAndSwap handled below.
"(*Bool).Load", "(*Bool).Load",