From f38573358cbedf46d64c5759ef41b72afcf0c5c0 Mon Sep 17 00:00:00 2001 From: "Hana (Hyang-Ah) Kim" Date: Wed, 25 May 2022 09:47:47 -0400 Subject: [PATCH] internal/gocommand: skip ill-formed env vars in cmdDebugStr Fixes golang/vscode-go#2260 Change-Id: I4dbdb1d582e3b434bce9f0e923899d8af6a43f3d Reviewed-on: https://go-review.googlesource.com/c/tools/+/408376 gopls-CI: kokoro TryBot-Result: Gopher Robot Reviewed-by: Robert Findley Run-TryBot: Hyang-Ah Hana Kim --- internal/gocommand/invoke.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/internal/gocommand/invoke.go b/internal/gocommand/invoke.go index f753368346..67256dc397 100644 --- a/internal/gocommand/invoke.go +++ b/internal/gocommand/invoke.go @@ -264,8 +264,10 @@ func cmdDebugStr(cmd *exec.Cmd) string { env := make(map[string]string) for _, kv := range cmd.Env { split := strings.SplitN(kv, "=", 2) - k, v := split[0], split[1] - env[k] = v + if len(split) == 2 { + k, v := split[0], split[1] + env[k] = v + } } var args []string