From eeb95ae5ed21dbcf7ae1d799ba57f5860169893f Mon Sep 17 00:00:00 2001 From: Robert Findley Date: Wed, 2 Feb 2022 09:44:54 -0500 Subject: [PATCH] gopls: make 'fastfuzzy' the default fuzzy matcher for workspace symbols For dense queries, the fastfuzzy matcher is around 3x faster. It also has improved scoring for exact matches of CamelCase words or path segments. Fixes golang/go#50016 Change-Id: I04cae11cbc54de59d54733836876a9ee759c80b6 Reviewed-on: https://go-review.googlesource.com/c/tools/+/382394 Trust: Robert Findley Run-TryBot: Robert Findley TryBot-Result: Gopher Robot Reviewed-by: Hyang-Ah Hana Kim gopls-CI: kokoro --- gopls/doc/settings.md | 2 +- internal/lsp/source/api_json.go | 2 +- internal/lsp/source/options.go | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/gopls/doc/settings.md b/gopls/doc/settings.md index ee9a74e06e..dfa8ff64b7 100644 --- a/gopls/doc/settings.md +++ b/gopls/doc/settings.md @@ -398,7 +398,7 @@ Must be one of: * `"FastFuzzy"` * `"Fuzzy"` -Default: `"Fuzzy"`. +Default: `"FastFuzzy"`. ##### **symbolStyle** *enum* diff --git a/internal/lsp/source/api_json.go b/internal/lsp/source/api_json.go index 8249fb471b..78a4af50b7 100755 --- a/internal/lsp/source/api_json.go +++ b/internal/lsp/source/api_json.go @@ -185,7 +185,7 @@ var GeneratedAPIJSON = &APIJSON{ {Value: "\"FastFuzzy\""}, {Value: "\"Fuzzy\""}, }, - Default: "\"Fuzzy\"", + Default: "\"FastFuzzy\"", Status: "advanced", Hierarchy: "ui.navigation", }, diff --git a/internal/lsp/source/options.go b/internal/lsp/source/options.go index 07acdf7972..98ef2aeaa4 100644 --- a/internal/lsp/source/options.go +++ b/internal/lsp/source/options.go @@ -133,7 +133,7 @@ func DefaultOptions() *Options { }, NavigationOptions: NavigationOptions{ ImportShortcut: Both, - SymbolMatcher: SymbolFuzzy, + SymbolMatcher: SymbolFastFuzzy, SymbolStyle: DynamicSymbols, }, CompletionOptions: CompletionOptions{