From eb0d8dd85bcce4e3c0c1da6bbc384d5ad84035bf Mon Sep 17 00:00:00 2001 From: vovapi Date: Sun, 19 Jan 2020 21:40:37 +0000 Subject: [PATCH] go/ssa: remove workaround for lack of vendoring in go/loader Support for vendoring in go/loader was added in golang.org/cl/18053 Similar workaround was removed from go/loader tests in golang.org/cl/18214 Resolves TODO left by adonovan Change-Id: I418463feb3e2dded191b6f1770dd7b9e44c2deca GitHub-Last-Rev: b556acfce87ab1bac9a73b69202a1afdd6e641cc GitHub-Pull-Request: golang/tools#199 Reviewed-on: https://go-review.googlesource.com/c/tools/+/215458 Run-TryBot: Brad Fitzpatrick TryBot-Result: Gobot Gobot Reviewed-by: Brad Fitzpatrick --- go/ssa/stdlib_test.go | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/go/ssa/stdlib_test.go b/go/ssa/stdlib_test.go index 8aa3682dba..41b87ff2a6 100644 --- a/go/ssa/stdlib_test.go +++ b/go/ssa/stdlib_test.go @@ -28,18 +28,6 @@ import ( "golang.org/x/tools/internal/testenv" ) -// Skip the set of packages that transitively depend on -// cmd/internal/objfile, which uses vendoring, -// which go/loader does not yet support. -// TODO(adonovan): add support for vendoring and delete this. -var skip = map[string]bool{ - "cmd/addr2line": true, - "cmd/internal/objfile": true, - "cmd/nm": true, - "cmd/objdump": true, - "cmd/pprof": true, -} - func bytesAllocated() uint64 { runtime.GC() var stats runtime.MemStats @@ -62,9 +50,6 @@ func TestStdlib(t *testing.T) { ctxt.GOPATH = "" // disable GOPATH conf := loader.Config{Build: &ctxt} for _, path := range buildutil.AllPackages(conf.Build) { - if skip[path] { - continue - } conf.ImportWithTests(path) }