From eb0b8a15bcda2a8a3693de0e25d85444df4016a4 Mon Sep 17 00:00:00 2001
From: OneOfOne <oneofone@gmail.com>
Date: Tue, 25 May 2021 18:51:47 -0500
Subject: [PATCH] internal/lsp: findIdentifier always return an error

Fixes golang/vscode-go#1522

Change-Id: I9da0e5486e1494cf7948beefa26f57d89d5b3933
Reviewed-on: https://go-review.googlesource.com/c/tools/+/322651
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
Trust: Rebecca Stambler <rstambler@golang.org>
Trust: Michael Knyszek <mknyszek@google.com>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
---
 internal/lsp/source/identifier.go | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/internal/lsp/source/identifier.go b/internal/lsp/source/identifier.go
index 77f496455c..9fb3daa28b 100644
--- a/internal/lsp/source/identifier.go
+++ b/internal/lsp/source/identifier.go
@@ -276,7 +276,7 @@ func findIdentifier(ctx context.Context, snapshot Snapshot, pkg Package, pgf *Pa
 
 	declPkg, err := FindPackageFromPos(ctx, snapshot, result.Declaration.obj.Pos())
 	if err != nil {
-		return nil, nil
+		return nil, err
 	}
 	if result.Declaration.node, err = snapshot.PosToDecl(ctx, declPkg, result.Declaration.obj.Pos()); err != nil {
 		return nil, err