mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

net: check 'ok' return in dnsmsg when initially packing rr.Header() 

In the present code, there is no way for ok to ever return false, but
it still a good idea to check it.

Change-Id: I8f360018b33a5d85dabbbbec0f89ffc81f77ecbb
Reviewed-on: https://go-review.googlesource.com/13956
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
This commit is contained in:
Tarmigan Casebolt 2015-08-23 19:51:31 -07:00 committed by Minux Ma
parent 9172a1b573
commit e643dc79d4
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/net/dnsmsg.go
View File

@ -691,6 +691,9 @@ func packRR(rr dnsRR, msg []byte, off int) (off2 int, ok bool) {
// off1 is end of header
// off2 is end of rr
off1, ok = packStruct(rr.Header(), msg, off)
if !ok {
return len(msg), false
}
off2, ok = packStruct(rr, msg, off)
if !ok {
return len(msg), false