From de58e7c01d4975df1d38eae7d24b8a8b3ac9ff5f Mon Sep 17 00:00:00 2001 From: Keith Randall Date: Fri, 4 Dec 2020 15:48:42 -0800 Subject: [PATCH] go/analysis/passes/framepointer: don't report on runtime package Skip the runtime package as it does lots of stack switching that causes false positives. Change-Id: I001c5750db9f53b270073a05b4ae322141f4c49a Reviewed-on: https://go-review.googlesource.com/c/tools/+/275518 Trust: Keith Randall Run-TryBot: Keith Randall gopls-CI: kokoro TryBot-Result: Go Bot Reviewed-by: Michael Matloob --- go/analysis/passes/framepointer/framepointer.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/go/analysis/passes/framepointer/framepointer.go b/go/analysis/passes/framepointer/framepointer.go index 6c13eeb4ae..741492e477 100644 --- a/go/analysis/passes/framepointer/framepointer.go +++ b/go/analysis/passes/framepointer/framepointer.go @@ -41,7 +41,7 @@ func run(pass *analysis.Pass) (interface{}, error) { // Find assembly files to work on. var sfiles []string for _, fname := range pass.OtherFiles { - if strings.HasSuffix(fname, ".s") { + if strings.HasSuffix(fname, ".s") && pass.Pkg.Path() != "runtime" { sfiles = append(sfiles, fname) } }