From dd255f23517e12f99e036a76f0b414cbadfe50cd Mon Sep 17 00:00:00 2001 From: Muir Manders Date: Wed, 5 May 2021 13:29:57 -0700 Subject: [PATCH] lsp/source: enable experimentalPostfixCompletions by default Leave the options flag so people can disable it for now if needed. Updates golang/go#39507. Change-Id: I78bbac157caa18c5d9a8e2ffe1a5c5eba4c6c30f Reviewed-on: https://go-review.googlesource.com/c/tools/+/317389 Run-TryBot: Muir Manders Run-TryBot: Rebecca Stambler gopls-CI: kokoro TryBot-Result: Go Bot Reviewed-by: Rebecca Stambler Trust: Rebecca Stambler Trust: Peter Weinberger --- gopls/doc/settings.md | 2 +- internal/lsp/source/api_json.go | 2 +- internal/lsp/source/options.go | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/gopls/doc/settings.md b/gopls/doc/settings.md index 449a362291..f2de5b1202 100644 --- a/gopls/doc/settings.md +++ b/gopls/doc/settings.md @@ -246,7 +246,7 @@ Default: `"Fuzzy"`. experimentalPostfixCompletions enables artifical method snippets such as "someSlice.sort!". -Default: `false`. +Default: `true`. #### Diagnostic diff --git a/internal/lsp/source/api_json.go b/internal/lsp/source/api_json.go index bec11d57a2..3d140a5423 100755 --- a/internal/lsp/source/api_json.go +++ b/internal/lsp/source/api_json.go @@ -265,7 +265,7 @@ var GeneratedAPIJSON = &APIJSON{ Keys: nil, }, EnumValues: nil, - Default: "false", + Default: "true", Status: "experimental", Hierarchy: "ui.completion", }, diff --git a/internal/lsp/source/options.go b/internal/lsp/source/options.go index 626b1c2c0b..91e5cb4789 100644 --- a/internal/lsp/source/options.go +++ b/internal/lsp/source/options.go @@ -133,7 +133,7 @@ func DefaultOptions() *Options { CompletionOptions: CompletionOptions{ Matcher: Fuzzy, CompletionBudget: 100 * time.Millisecond, - ExperimentalPostfixCompletions: false, + ExperimentalPostfixCompletions: true, }, Codelenses: map[string]bool{ string(command.Generate): true,