mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Revert "cmd/go: report gcc ld error message when linking fails" 

This reverts CL 646315.

Reason for revert: broke cgo_undef test

Change-Id: Ic992a1666a446736c605a8caefa77f791dceb64c
Reviewed-on: https://go-review.googlesource.com/c/go/+/647415
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This commit is contained in:
Quim Muntal 2025-02-06 13:16:34 -08:00 committed by Cherry Mui
parent 9125e214a1
commit d9d87edc56
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/cmd/go/internal/work/exec.go
View File

@ -2208,7 +2208,7 @@ func (b *Builder) gccld(a *Action, objdir, outfile string, flags []string, objs
}
cmdargs := []any{cmd, "-o", outfile, objs, flags}
out, err := sh.runOut(base.Cwd(), b.cCompilerEnv(), cmdargs...)
_, err := sh.runOut(base.Cwd(), b.cCompilerEnv(), cmdargs...)
// Note that failure is an expected outcome here, so we report output only
// in debug mode and don't report the error.
@ -2217,7 +2217,7 @@ func (b *Builder) gccld(a *Action, objdir, outfile string, flags []string, objs
if err != nil {
saw = "failed"
}
sh.ShowCmd("", "%s # test for internal linking errors (%s)\n%s", joinUnambiguously(str.StringList(cmdargs...)), saw, out)
sh.ShowCmd("", "%s # test for internal linking errors (%s)", joinUnambiguously(str.StringList(cmdargs...)), saw)
}
return err