mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

cmd/compile: fix offset calculation error in memcombine 

Fixes #73812

Change-Id: If7a6e103ae9e1442a2cf4a3c6b1270b6a1887196
Reviewed-on: https://go-review.googlesource.com/c/go/+/675175
Reviewed-by: Keith Randall <khr@google.com>
Auto-Submit: Junyang Shao <shaojunyang@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This commit is contained in:
Junyang Shao 2025-05-21 18:50:39 +00:00 committed by Gopher Robot
parent a21b71daf5
commit d6c29c7156
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/cmd/compile/internal/ssa/memcombine.go
View File

@ -581,7 +581,7 @@ func combineStores(root *Value) {
mask := int64(1)<<(8*a[i].size) - 1 mask := int64(1)<<(8*a[i].size) - 1
s := 8 * (a[i].offset - a[0].offset) s := 8 * (a[i].offset - a[0].offset)
if root.Block.Func.Config.BigEndian { if root.Block.Func.Config.BigEndian {
s = aTotalSize*8 - a[i].size - s s = (aTotalSize-a[i].size)*8 - s
} }
c |= (a[i].store.Args[1].AuxInt & mask) << s c |= (a[i].store.Args[1].AuxInt & mask) << s
} }

9
test/codegen/issue72832.go
View File

@ -35,7 +35,16 @@ type tile3 struct {
func store_shifted(t *tile3, x uint32) { func store_shifted(t *tile3, x uint32) {
// amd64:`MOVL` // amd64:`MOVL`
// ppc64:`MOVHBR`
t.a = uint8(x) t.a = uint8(x)
t.b = uint8(x >> 8) t.b = uint8(x >> 8)
t.c = uint16(x >> 16) t.c = uint16(x >> 16)
} }
func store_const(t *tile3) {
// 0x00030201
// amd64:`MOVL\s\$197121`
// 0x01020003
// ppc64:`MOVD\s\$16908291`
t.a, t.b, t.c = 1, 2, 3
}