From d456b1cd8c8645ed4775eda69782a3cfaf0429f3 Mon Sep 17 00:00:00 2001 From: Heschi Kreinick Date: Tue, 21 Jan 2020 14:51:24 -0500 Subject: [PATCH] internal/imports: pass dummy source for completion functions The goimports code tries to read source from disk if none is supplied, but the completion functions don't need source. Pass a dummy slice. Fixes golang/go#36671. Change-Id: Ieecc9ee75d39f8f165c7b9764ff49c8334a7fcd2 Reviewed-on: https://go-review.googlesource.com/c/tools/+/215681 Run-TryBot: Heschi Kreinick Reviewed-by: Rebecca Stambler TryBot-Result: Gobot Gobot --- internal/imports/imports.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/imports/imports.go b/internal/imports/imports.go index 7c08eed660..2e7a317e55 100644 --- a/internal/imports/imports.go +++ b/internal/imports/imports.go @@ -119,7 +119,7 @@ func ApplyFixes(fixes []*ImportFix, filename string, src []byte, opt *Options, e // GetAllCandidates gets all of the packages starting with prefix that can be // imported by filename, sorted by import path. func GetAllCandidates(ctx context.Context, callback func(ImportFix), searchPrefix, filename, filePkg string, opt *Options) error { - _, opt, err := initialize(filename, nil, opt) + _, opt, err := initialize(filename, []byte{}, opt) if err != nil { return err } @@ -128,7 +128,7 @@ func GetAllCandidates(ctx context.Context, callback func(ImportFix), searchPrefi // GetPackageExports returns all known packages with name pkg and their exports. func GetPackageExports(ctx context.Context, callback func(PackageExport), searchPkg, filename, filePkg string, opt *Options) error { - _, opt, err := initialize(filename, nil, opt) + _, opt, err := initialize(filename, []byte{}, opt) if err != nil { return err }