mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

nits, fix error message for moveTo

This commit is contained in:
Ryan Berger 2023-09-09 16:23:11 -06:00
parent 0cbf73b126
commit cdffffdb12
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/cmd/compile/internal/ssa/ilp.go
View File

@ -4,7 +4,7 @@
package ssa package ssa
// ilp pass (Instruction Level Parallelism) balances trees of commutative computation // ilp pass (Instruction Level Parallelism) balances trees of associative computation
// to help CPU pipeline instructions more efficiently. It only works block by block // to help CPU pipeline instructions more efficiently. It only works block by block
// so that it doesn't end up pulling loop invariant expressions into tight loops // so that it doesn't end up pulling loop invariant expressions into tight loops
func ilp(f *Func) { func ilp(f *Func) {
@ -15,15 +15,15 @@ func ilp(f *Func) {
} }
} }
// isILPOp only returns true if the operation is commutative // isILPOp only returns true if the operation is associative,
// and associative, which for our case would be only commutative integer ops. // which for our case would be only commutative integer ops.
func isILPOp(o Op) bool { func isILPOp(o Op) bool {
// if the op isn't commutative it won't be useable for ilp // if the op isn't a commutative integer op, it won't be associative
if !opcodeTable[o].commutative { if !opcodeTable[o].commutative {
return false return false
} }
// filter out float ops because they are not associative // filter out float ops because they are not associative, leaving int ops
switch o { switch o {
case OpAdd32F, OpAdd64F, OpMul32F, OpMul64F: case OpAdd32F, OpAdd64F, OpMul32F, OpMul64F:
return false return false
@ -87,7 +87,7 @@ func balanceExprTree(nodes, leaves []*Value) {
subTrees := leaves subTrees := leaves
i := len(nodes)-1 i := len(nodes)-1
for len(subTrees) != 1 { for len(subTrees) != 1 {
nextSubTrees := make([]*Value, 0, (len(subTrees)+1)/2) nextSubTrees := subTrees[:0]
start := len(subTrees) % 2 start := len(subTrees) % 2
if start != 0 { if start != 0 {
@ -142,7 +142,7 @@ func rebalance(v *Value) {
} }
} }
// we need at least 3 nodes (root, two children) and len(args)^2 leaves // we need at least 3 nodes (root, two children) and 4 leaves
// for this expression to be rebalanceable // for this expression to be rebalanceable
if len(nodes) < 3 || len(leaves) < 4 { if len(nodes) < 3 || len(leaves) < 4 {
return return

2
src/cmd/compile/internal/ssa/shortcircuit.go
View File

@ -499,7 +499,7 @@ func (v *Value) moveTo(dst *Block, i int) {
} }
src := v.Block src := v.Block
if src.Values[i] != v { if src.Values[i] != v {
v.Fatalf("moveTo bad index %d", i) v.Fatalf("moveTo bad index %d, src.Values[i] = %v, expected %v", i, src.Values[i], v)
} }
if src == dst { if src == dst {
return return