mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

runtime: do not use heap arena hints on wasm 

The address space of WebAssembly's linear memory is contiguous, so
requesting specific addresses is not supported. Do not use heap arena
hints so we do not have unused memory ranges.

This fixes go1 benchmarks on wasm which ran out of memory since
https://golang.org/cl/170950.

Change-Id: I70115b18dbe43abe16dd5f57996343d97bf94760
Reviewed-on: https://go-review.googlesource.com/c/go/+/174203
Run-TryBot: Richard Musiol <neelance@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
This commit is contained in:
Richard Musiol 2019-04-28 12:16:44 +02:00 committed by Richard Musiol
parent dcb84828a6
commit c2d9eea1f1
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/runtime/mem_js.go
View File

@ -41,13 +41,19 @@ var reserveEnd uintptr
func sysReserve(v unsafe.Pointer, n uintptr) unsafe.Pointer {
// TODO(neelance): maybe unify with mem_plan9.go, depending on how https://github.com/WebAssembly/design/blob/master/FutureFeatures.md#finer-grained-control-over-memory turns out
if v != nil {
// The address space of WebAssembly's linear memory is contiguous,
// so requesting specific addresses is not supported. We could use
// a different address, but then mheap.sysAlloc discards the result
// right away and we don't reuse chunks passed to sysFree.
return nil
}
if reserveEnd < lastmoduledatap.end {
reserveEnd = lastmoduledatap.end
}
if uintptr(v) < reserveEnd {
v = unsafe.Pointer(reserveEnd)
}
reserveEnd = uintptr(v) + n
v = unsafe.Pointer(reserveEnd)
reserveEnd += n
current := currentMemory()
needed := int32(reserveEnd/sys.DefaultPhysPageSize + 1)