mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

internal/lsp/source: enable type error analyzers 

I had intended to enable these after gopls/v0.4.0 was released so that
people who test at master can try these out. Also, mark "fillreturns" as
high confidence so users can get it applied on save, much like
goreturns.

Change-Id: I71aa0b723b2e9b69474ceed7cb1d7da7c929d65d
Reviewed-on: https://go-review.googlesource.com/c/tools/+/228724
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
This commit is contained in:
Rebecca Stambler 2020-04-17 00:21:51 -04:00
parent e33929705b
commit c07e33ef32
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
internal/lsp/source/options.go
View File

@ -498,23 +498,24 @@ func (r *OptionResult) setBool(b *bool) {
func typeErrorAnalyzers() map[string]Analyzer {
return map[string]Analyzer{
fillreturns.Analyzer.Name: {
Analyzer: fillreturns.Analyzer,
enabled: false,
FixesError: fillreturns.FixesError,
Analyzer: fillreturns.Analyzer,
enabled: true,
FixesError: fillreturns.FixesError,
HighConfidence: true,
},
nonewvars.Analyzer.Name: {
Analyzer: nonewvars.Analyzer,
enabled: false,
enabled: true,
FixesError: nonewvars.FixesError,
},
noresultvalues.Analyzer.Name: {
Analyzer: noresultvalues.Analyzer,
enabled: false,
enabled: true,
FixesError: noresultvalues.FixesError,
},
undeclaredname.Analyzer.Name: {
Analyzer: undeclaredname.Analyzer,
enabled: false,
enabled: true,
FixesError: undeclaredname.FixesError,
},
}