mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

go/printer: simply ignore filename changes in position information 

There's no good reason to make any printer state adjustments
simply because the file name in node position information has
changed. Eliminate the relevant code.

R=r
CC=golang-dev
https://golang.org/cl/6856054
This commit is contained in:
Robert Griesemer 2012-11-19 13:23:32 -08:00
parent 09f3c2f10f
commit c00bda1352
1 changed files with 0 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/pkg/go/printer/printer.go
View File

@ -221,21 +221,6 @@ func (p *printer) writeString(pos token.Position, s string, isLit bool) {
// atLineBegin updates p.pos if there's indentation, but p.pos // atLineBegin updates p.pos if there's indentation, but p.pos
// is the position of s. // is the position of s.
p.pos = pos p.pos = pos
// reset state if the file changed
// (used when printing merged ASTs of different files
// e.g., the result of ast.MergePackageFiles)
if p.last.IsValid() && p.last.Filename != pos.Filename {
// Note: Do not set p.indent to 0 - this seems to be a bad heuristic.
// ASTs may be created by various tools and built from nodes of
// different files. An incorrectly constructed AST will likely
// not print at all, but a (structurally) correct AST with bad
// position information should still print structurally correct.
// If p.indent is reset, indentation may be off, and likely lead
// to indentation underflow (to detect set: debug = true).
// See also issue 4300 (11/16/2012).
p.mode = 0
p.wsbuf = p.wsbuf[0:0]
}
} }
if isLit { if isLit {