mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

internal/lsp: fix error suppression in (*session).createView 

I had mistakenly forgotten to return a snapshot along with the view.

Fixes golang/go#36020

Change-Id: I1fc802b8924fccec1d6aaa110640eaed490c3aa1
Reviewed-on: https://go-review.googlesource.com/c/tools/+/210215
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
This commit is contained in:
Rebecca Stambler 2019-12-06 15:15:20 -05:00
parent 6d582d504c
commit bc369361f3
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
internal/lsp/cache/session.go vendored
View File

@ -137,7 +137,7 @@ func (s *session) createView(ctx context.Context, name string, folder span.URI,
if err != nil {
// Suppress all errors.
log.Error(ctx, "failed to load snapshot", err, telemetry.Directory.Of(folder))
return v, nil, nil
return v, v.snapshot, nil
}
// Prepare CheckPackageHandles for every package that's been loaded.
// (*snapshot).CheckPackageHandle makes the assumption that every package that's
@ -145,7 +145,7 @@ func (s *session) createView(ctx context.Context, name string, folder span.URI,
if _, err := v.snapshot.checkWorkspacePackages(ctx, m); err != nil {
// Suppress all errors.
log.Error(ctx, "failed to check snapshot", err, telemetry.Directory.Of(folder))
return v, nil, nil
return v, v.snapshot, nil
}
debug.AddView(debugView{v})