mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

misc/dashboard/codereview: only accept "NOT LGTM" on the first line of a message. 

Too many people quote entire emails and put their reply at the top ("top posting"),
so we shouldn't recognise review commands anywhere in the review text.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6815048
This commit is contained in:
David Symonds 2012-10-29 22:03:58 +11:00
parent ee3e2ac1a6
commit b506c3e17a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
misc/dashboard/codereview/dashboard/cl.go
View File

@ -389,7 +389,7 @@ func updateCL(c appengine.Context, n string) error {
lgtm[s] = true lgtm[s] = true
delete(notLGTM, s) // "LGTM" overrules previous "NOT LGTM" delete(notLGTM, s) // "LGTM" overrules previous "NOT LGTM"
} }
if strings.Contains(msg.Text, "NOT LGTM") { if strings.Contains(line, "NOT LGTM") {
notLGTM[s] = true notLGTM[s] = true
delete(lgtm, s) // "NOT LGTM" overrules previous "LGTM" delete(lgtm, s) // "NOT LGTM" overrules previous "LGTM"
} }