mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

math: remove riscv64 assembly implementations of rounding 

Fixes #68322

This reverts commit ad377e906a.

Change-Id: Ifa4811e2c679d789cc830dbff5e50301410e24d0
Reviewed-on: https://go-review.googlesource.com/c/go/+/596516
Reviewed-by: Than McIntosh <thanm@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
Commit-Queue: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Auto-Submit: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Keith Randall <khr@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
This commit is contained in:
Jorropo 2024-07-06 04:48:04 +02:00 committed by Gopher Robot
parent 70e453b436
commit b3040679ad
4 changed files with 19 additions and 43 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/math/floor_asm.go
View File

@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style // Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file. // license that can be found in the LICENSE file.
//go:build 386 || amd64 || arm64 || ppc64 || ppc64le || riscv64 || s390x || wasm //go:build 386 || amd64 || arm64 || ppc64 || ppc64le || s390x || wasm
package math package math

2
src/math/floor_noasm.go
View File

@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style // Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file. // license that can be found in the LICENSE file.
//go:build !386 && !amd64 && !arm64 && !ppc64 && !ppc64le && !riscv64 && !s390x && !wasm //go:build !386 && !amd64 && !arm64 && !ppc64 && !ppc64le && !s390x && !wasm
package math package math

41
src/math/floor_riscv64.s
View File

@ -1,41 +0,0 @@
// Copyright 2023 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
#include "textflag.h"
#define PosInf 0x7FF0000000000000
// The rounding mode of RISC-V is different from Go spec.
#define ROUNDFN(NAME, MODE) \
TEXT NAME(SB),NOSPLIT,$0; \
MOVD x+0(FP), F0; \
/* whether x is NaN */; \
FEQD F0, F0, X6; \
BNEZ X6, 3(PC); \
/* return NaN if x is NaN */; \
MOVD F0, ret+8(FP); \
RET; \
MOV $PosInf, X6; \
FMVDX X6, F1; \
FABSD F0, F2; \
/* if abs(x) > +Inf, return Inf instead of round(x) */; \
FLTD F1, F2, X6; \
/* Inf should keep same signed with x then return */; \
BEQZ X6, 3(PC); \
FCVTLD.MODE F0, X6; \
FCVTDL X6, F1; \
/* rounding will drop signed bit in RISCV, restore it */; \
FSGNJD F0, F1, F0; \
MOVD F0, ret+8(FP); \
RET
// func archFloor(x float64) float64
ROUNDFN(·archFloor, RDN)
// func archCeil(x float64) float64
ROUNDFN(·archCeil, RUP)
// func archTrunc(x float64) float64
ROUNDFN(·archTrunc, RTZ)

17
test/fixedbugs/issue68322.go Normal file
View File

@ -0,0 +1,17 @@
// run
// Copyright 2024 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
package main
import "math"
var doNotFold = 18446744073709549568.0
func main() {
if math.Trunc(doNotFold) != doNotFold {
panic("big (over 2**63-1) math.Trunc is incorrect")
}
}