mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

gopls/internal/regtest: unskip tests for golang/go#37098 

Now that this issue has been resolved, we can unskip the tests for it.

Change-Id: I610122a424bedd2cbd066ea9985239fc319e58ae
Reviewed-on: https://go-review.googlesource.com/c/tools/+/313532
Trust: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
This commit is contained in:
Rebecca Stambler 2021-04-26 15:13:50 -04:00
parent 28c1392e35
commit aec13729f1
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
gopls/internal/regtest/diagnostics/diagnostics_test.go
View File

@ -8,6 +8,7 @@ import (
"context"
"fmt"
"log"
"os/exec"
"testing"
"golang.org/x/tools/gopls/internal/hooks"
@ -1381,7 +1382,15 @@ func b(c bytes.Buffer) {
}
func TestSwig(t *testing.T) {
t.Skipf("skipped until golang/go#37098 is resolved")
// This is fixed in Go 1.17, but not earlier.
testenv.NeedsGo1Point(t, 17)
if _, err := exec.LookPath("swig"); err != nil {
t.Skip("skipping test: swig not available")
}
if _, err := exec.LookPath("g++"); err != nil {
t.Skip("skipping test: g++ not available")
}
const mod = `
-- go.mod --