mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

go/ast: deprecate FilterPackage, PackageExports, MergePackageFiles 

(More symbols that belong to the ast.Object deprecation.)

Fixes #73088
Fixes #7124
Updates #52463
Updates #71122

Change-Id: I10e3ef35b587da2f3f0a65e9154e33bd53e7a093
Reviewed-on: https://go-review.googlesource.com/c/go/+/674176
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Robert Griesemer <gri@google.com>
This commit is contained in:
Alan Donovan 2025-05-19 14:11:51 -04:00
parent 8dd7d2111b
commit ae0824883e
3 changed files with 25 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
api/next/73088.txt Normal file
View File

@ -0,0 +1,7 @@
pkg go/ast, const FilterFuncDuplicates //deprecated #73088
pkg go/ast, const FilterImportDuplicates //deprecated #73088
pkg go/ast, const FilterUnassociatedComments //deprecated #73088
pkg go/ast, func FilterPackage //deprecated #73088
pkg go/ast, func MergePackageFiles //deprecated #73088
pkg go/ast, func PackageExports //deprecated #73088
pkg go/ast, type MergeMode //deprecated #73088

4
doc/next/6-stdlib/99-minor/go/ast/73088.md Normal file
View File

@ -0,0 +1,4 @@
The [ast.FilterPackage], [ast.PackageExports], and
[ast.MergePackageFiles] functions, and the [MergeMode] type and its
constants, are all deprecated, as they are for use only with the
long-deprecated [ast.Object] and [ast.Package] machinery.

14
src/go/ast/filter.go
View File

@ -34,6 +34,9 @@ func FileExports(src *File) bool {
// //
// PackageExports reports whether there are exported declarations; // PackageExports reports whether there are exported declarations;
// it returns false otherwise. // it returns false otherwise.
//
// Deprecated: use the type checker [go/types] instead of [Package];
// see [Object]. Alternatively, use [FileExports].
func PackageExports(pkg *Package) bool { func PackageExports(pkg *Package) bool {
return filterPackage(pkg, exportFilter, true) return filterPackage(pkg, exportFilter, true)
} }
@ -276,6 +279,9 @@ func filterFile(src *File, f Filter, export bool) bool {
// //
// FilterPackage reports whether there are any top-level declarations // FilterPackage reports whether there are any top-level declarations
// left after filtering. // left after filtering.
//
// Deprecated: use the type checker [go/types] instead of [Package];
// see [Object]. Alternatively, use [FilterFile].
func FilterPackage(pkg *Package, f Filter) bool { func FilterPackage(pkg *Package, f Filter) bool {
return filterPackage(pkg, f, false) return filterPackage(pkg, f, false)
} }
@ -294,8 +300,13 @@ func filterPackage(pkg *Package, f Filter, export bool) bool {
// Merging of package files // Merging of package files
// The MergeMode flags control the behavior of [MergePackageFiles]. // The MergeMode flags control the behavior of [MergePackageFiles].
//
// Deprecated: use the type checker [go/types] instead of [Package];
// see [Object].
type MergeMode uint type MergeMode uint
// Deprecated: use the type checker [go/types] instead of [Package];
// see [Object].
const ( const (
// If set, duplicate function declarations are excluded. // If set, duplicate function declarations are excluded.
FilterFuncDuplicates MergeMode = 1 << iota FilterFuncDuplicates MergeMode = 1 << iota
@ -332,6 +343,9 @@ var separator = &Comment{token.NoPos, "//"}
// MergePackageFiles creates a file AST by merging the ASTs of the // MergePackageFiles creates a file AST by merging the ASTs of the
// files belonging to a package. The mode flags control merging behavior. // files belonging to a package. The mode flags control merging behavior.
//
// Deprecated: this function is poorly specified and has unfixable
// bugs; also [Package] is deprecated.
func MergePackageFiles(pkg *Package, mode MergeMode) *File { func MergePackageFiles(pkg *Package, mode MergeMode) *File {
// Count the number of package docs, comments and declarations across // Count the number of package docs, comments and declarations across
// all package files. Also, compute sorted list of filenames, so that // all package files. Also, compute sorted list of filenames, so that