From a5321bfa33c5e06fa0b8793de432db7c9811bc80 Mon Sep 17 00:00:00 2001 From: Than McIntosh Date: Mon, 8 Nov 2021 14:39:46 -0500 Subject: [PATCH] go/internal/gccgoimporter: skip installation test on AIX Skip the installation test when running on AIX. For this test to work properly on AIX, we need to port CL 152720 (or something like it) here from the main repo. Fixes golang/go/#49445. Updates golang/go#29113. Change-Id: Idf1f9d717aa835b80cffa4e3ab34ae578a809860 Reviewed-on: https://go-review.googlesource.com/c/tools/+/362248 gopls-CI: kokoro Trust: Than McIntosh Run-TryBot: Than McIntosh TryBot-Result: Go Bot Reviewed-by: Bryan C. Mills --- go/internal/gccgoimporter/gccgoinstallation_test.go | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/go/internal/gccgoimporter/gccgoinstallation_test.go b/go/internal/gccgoimporter/gccgoinstallation_test.go index 9155f93117..5bf7f11cbd 100644 --- a/go/internal/gccgoimporter/gccgoinstallation_test.go +++ b/go/internal/gccgoimporter/gccgoinstallation_test.go @@ -9,6 +9,7 @@ package gccgoimporter import ( "go/types" + "runtime" "testing" ) @@ -156,6 +157,12 @@ func TestInstallationImporter(t *testing.T) { if gpath == "" { t.Skip("This test needs gccgo") } + if runtime.GOOS == "aix" { + // We don't yet have a debug/xcoff package for reading + // object files on AIX. Remove this skip if/when issue #29038 + // is implemented (see also issue #49445). + t.Skip("no support yet for debug/xcoff") + } var inst GccgoInstallation err := inst.InitFromDriver(gpath)