mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

crypto/x509: skip broken darwin root tests 

For #57428.
For #35678.

Change-Id: I806c16d3ff3815b8681916753338356c444970d2
Reviewed-on: https://go-review.googlesource.com/c/go/+/482165
Reviewed-by: Bryan Mills <bcmills@google.com>
Auto-Submit: Michael Pratt <mpratt@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Michael Pratt <mpratt@google.com>
This commit is contained in:
Michael Pratt 2023-04-10 11:25:06 -04:00 committed by Gopher Robot
parent 80eeec6979
commit 9efca84066
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/crypto/x509/root_darwin_test.go
View File

@ -33,6 +33,7 @@ func TestPlatformVerifier(t *testing.T) {
verifyTime time.Time
verifyEKU []x509.ExtKeyUsage
expectedErr string
skip string
}{
{
// whatever google.com serves should, hopefully, be trusted
@ -64,11 +65,13 @@ func TestPlatformVerifier(t *testing.T) {
name: "revoked leaf",
host: "revoked.badssl.com",
expectedErr: "x509: “revoked.badssl.com” certificate is revoked",
skip: "skipping; broken on recent versions of macOS. See issue 57428.",
},
{
name: "leaf missing SCTs",
host: "no-sct.badssl.com",
expectedErr: "x509: “no-sct.badssl.com” certificate is not standards compliant",
skip: "skipping; broken on recent versions of macOS. See issue 57428.",
},
{
name: "expired leaf (custom time)",
@ -91,6 +94,10 @@ func TestPlatformVerifier(t *testing.T) {
for _, tc := range tests {
t.Run(tc.name, func(t *testing.T) {
if tc.skip != "" {
t.Skip(tc.skip)
}
chain := getChain(tc.host)
var opts x509.VerifyOptions
if len(chain) > 1 {