From 9eda97bc2d7c2fa6ed3f23c9511a6cdeb174b4c8 Mon Sep 17 00:00:00 2001 From: Michael Matloob Date: Mon, 10 Oct 2022 18:10:03 -0400 Subject: [PATCH] go/analysis: enable a test that applies after go list behavior change The despite-error case in TestRunDespiteErrors only returns error code 1 after golang.org/cl/437298. This CL enables the test for Go 1.20+. Change-Id: Ib212026d595e7bf872aa2482e1d91723010e7018 Reviewed-on: https://go-review.googlesource.com/c/tools/+/441880 Run-TryBot: Michael Matloob Reviewed-by: David Chase TryBot-Result: Gopher Robot Reviewed-by: Alan Donovan gopls-CI: kokoro --- go/analysis/internal/checker/checker_test.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/go/analysis/internal/checker/checker_test.go b/go/analysis/internal/checker/checker_test.go index d91425ee4a..f07963fa00 100644 --- a/go/analysis/internal/checker/checker_test.go +++ b/go/analysis/internal/checker/checker_test.go @@ -172,7 +172,8 @@ func Foo(s string) int { // no errors {name: "no-errors", pattern: []string{"sort"}, analyzers: []*analysis.Analyzer{analyzer, noop}, code: 0}, } { - if test.name == "despite-error" { // TODO(matloob): once CL 437298 is submitted, add the condition testenv.Go1Point() < 20 + if test.name == "despite-error" && testenv.Go1Point() < 20 { + // The behavior in the comment on the despite-error test only occurs for Go 1.20+. continue } if got := checker.Run(test.pattern, test.analyzers); got != test.code {