From 9c19d0db369a2767ae5290ef0fca972c874adef3 Mon Sep 17 00:00:00 2001 From: Ian Cottrell Date: Wed, 15 Apr 2020 10:12:57 -0400 Subject: [PATCH] internal/telemetry: delete the unit package It is not currently used at all, and is probably not the right approach. Now we can easily add type safe keys we can add ones for types that know their unit rather than storing it separately. Change-Id: If393ad1df76033cff571c46f98cde8decb722b9c Reviewed-on: https://go-review.googlesource.com/c/tools/+/228265 Run-TryBot: Ian Cottrell TryBot-Result: Gobot Gobot Reviewed-by: Robert Findley --- internal/telemetry/unit/unit.go | 19 ------------------- 1 file changed, 19 deletions(-) delete mode 100644 internal/telemetry/unit/unit.go diff --git a/internal/telemetry/unit/unit.go b/internal/telemetry/unit/unit.go deleted file mode 100644 index 596a5c779e..0000000000 --- a/internal/telemetry/unit/unit.go +++ /dev/null @@ -1,19 +0,0 @@ -// Copyright 2019 The Go Authors. All rights reserved. -// Use of this source code is governed by a BSD-style -// license that can be found in the LICENSE file. - -// Package unit holds the definitions for the units you can use in telemetry. -package unit - -// Unit is used to specify the units for a given measure. -// This is can used for display purposes. -type Unit string - -const ( - // Dimensionless indicates that a measure has no specified units. - Dimensionless = "1" - // Bytes indicates that that a measure is recording number of bytes. - Bytes = "By" - // Milliseconds indicates that a measure is recording a duration in milliseconds. - Milliseconds = "ms" -)