diff --git a/src/cmd/go/vcs.go b/src/cmd/go/vcs.go index 8a8ee4d349..06251a938d 100644 --- a/src/cmd/go/vcs.go +++ b/src/cmd/go/vcs.go @@ -500,7 +500,7 @@ func vcsFromDir(dir, srcRoot string) (vcs *vcsCmd, root string, err error) { origDir := dir for len(dir) > len(srcRoot) { for _, vcs := range vcsList { - if fi, err := os.Stat(filepath.Join(dir, "."+vcs.cmd)); err == nil && fi.IsDir() { + if _, err := os.Stat(filepath.Join(dir, "."+vcs.cmd)); err == nil { return vcs, filepath.ToSlash(dir[len(srcRoot)+1:]), nil } } diff --git a/src/cmd/go/vcs_test.go b/src/cmd/go/vcs_test.go index 9d84751398..798f6683a6 100644 --- a/src/cmd/go/vcs_test.go +++ b/src/cmd/go/vcs_test.go @@ -102,7 +102,7 @@ func TestRepoRootForImportPath(t *testing.T) { "git.openstack.org/openstack/swift.git", &repoRoot{ vcs: vcsGit, - repo: "https://git.openstack.org/openstack/swift", + repo: "https://git.openstack.org/openstack/swift.git", }, }, { @@ -174,11 +174,23 @@ func TestFromDir(t *testing.T) { } defer os.RemoveAll(tempDir) - for _, vcs := range vcsList { + for j, vcs := range vcsList { dir := filepath.Join(tempDir, "example.com", vcs.name, "."+vcs.cmd) - err := os.MkdirAll(dir, 0755) - if err != nil { - t.Fatal(err) + if j&1 == 0 { + err := os.MkdirAll(dir, 0755) + if err != nil { + t.Fatal(err) + } + } else { + err := os.MkdirAll(filepath.Dir(dir), 0755) + if err != nil { + t.Fatal(err) + } + f, err := os.Create(dir) + if err != nil { + t.Fatal(err) + } + f.Close() } want := repoRoot{