From 958971f5c2bf6dd2927330312acbda0ffd3758a0 Mon Sep 17 00:00:00 2001 From: Michael Matloob Date: Wed, 4 Sep 2019 16:52:49 -0400 Subject: [PATCH] go/ssa/interp: skip recover2 testcase The test case (taken from the go distribution itself) seems to be broken when run against tip. Disable it when run against tip. Updates golang/go#34089 Change-Id: I47d2e12ca39bc060fe0a0c967e95b900bdd0d725 Reviewed-on: https://go-review.googlesource.com/c/tools/+/193377 Run-TryBot: Michael Matloob Reviewed-by: Bryan C. Mills Reviewed-by: Rebecca Stambler TryBot-Result: Gobot Gobot --- go/ssa/interp/interp_test.go | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/go/ssa/interp/interp_test.go b/go/ssa/interp/interp_test.go index c1e30ec194..a216ac79f4 100644 --- a/go/ssa/interp/interp_test.go +++ b/go/ssa/interp/interp_test.go @@ -23,6 +23,7 @@ import ( "log" "os" "path/filepath" + "runtime" "strings" "testing" "time" @@ -124,6 +125,12 @@ var testdataTests = []string{ } func run(t *testing.T, input string) bool { + // The recover2 test case is broken when run against tip. See golang/go#34089. + // TODO(matloob): Figure out what's going on or fix this before go1.14 is released. + if filepath.Base(input) == "recover2.go" && strings.HasPrefix(runtime.Version(), "devel") { + t.Skip("The recover2.go test is broken in tip. See golang.org/issue/34089.") + } + t.Logf("Input: %s\n", input) start := time.Now()