cmd/compile/internal: intrinsify publicationBarrier on mips64x

This enables publicationBarrier to be used as an intrinsic on mips64x.

Change-Id: I4030ea65086c37ee1dcc1675d0d5d40ef8683851
Reviewed-on: https://go-review.googlesource.com/c/go/+/674855
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: David Chase <drchase@google.com>
Reviewed-by: Keith Randall <khr@google.com>
Auto-Submit: Keith Randall <khr@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
This commit is contained in:
Julian Zhu 2025-05-20 10:55:33 +08:00 committed by Gopher Robot
parent 77345f41ee
commit 94e3caeec1
7 changed files with 23 additions and 1 deletions

View File

@ -813,6 +813,9 @@ func ssaGenValue(s *ssagen.State, v *ssa.Value) {
p := s.Prog(obj.AGETCALLERPC) p := s.Prog(obj.AGETCALLERPC)
p.To.Type = obj.TYPE_REG p.To.Type = obj.TYPE_REG
p.To.Reg = v.Reg() p.To.Reg = v.Reg()
case ssa.OpMIPS64LoweredPubBarrier:
// SYNC
s.Prog(v.Op.Asm())
case ssa.OpClobber, ssa.OpClobberReg: case ssa.OpClobber, ssa.OpClobberReg:
// TODO: implement for clobberdead experiment. Nop is ok for now. // TODO: implement for clobberdead experiment. Nop is ok for now.
default: default:

View File

@ -476,6 +476,9 @@
// Write barrier. // Write barrier.
(WB ...) => (LoweredWB ...) (WB ...) => (LoweredWB ...)
// Publication barrier as intrinsic
(PubBarrier ...) => (LoweredPubBarrier ...)
(PanicBounds [kind] x y mem) && boundsABI(kind) == 0 => (LoweredPanicBoundsA [kind] x y mem) (PanicBounds [kind] x y mem) && boundsABI(kind) == 0 => (LoweredPanicBoundsA [kind] x y mem)
(PanicBounds [kind] x y mem) && boundsABI(kind) == 1 => (LoweredPanicBoundsB [kind] x y mem) (PanicBounds [kind] x y mem) && boundsABI(kind) == 1 => (LoweredPanicBoundsB [kind] x y mem)
(PanicBounds [kind] x y mem) && boundsABI(kind) == 2 => (LoweredPanicBoundsC [kind] x y mem) (PanicBounds [kind] x y mem) && boundsABI(kind) == 2 => (LoweredPanicBoundsC [kind] x y mem)

View File

@ -466,6 +466,9 @@ func init() {
// Returns a pointer to a write barrier buffer in R25. // Returns a pointer to a write barrier buffer in R25.
{name: "LoweredWB", argLength: 1, reg: regInfo{clobbers: (callerSave &^ gpg) | buildReg("R31"), outputs: []regMask{buildReg("R25")}}, clobberFlags: true, aux: "Int64"}, {name: "LoweredWB", argLength: 1, reg: regInfo{clobbers: (callerSave &^ gpg) | buildReg("R31"), outputs: []regMask{buildReg("R25")}}, clobberFlags: true, aux: "Int64"},
// Do data barrier. arg0=memorys
{name: "LoweredPubBarrier", argLength: 1, asm: "SYNC", hasSideEffects: true},
// There are three of these functions so that they can have three different register inputs. // There are three of these functions so that they can have three different register inputs.
// When we check 0 <= c <= cap (A), then 0 <= b <= c (B), then 0 <= a <= b (C), we want the // When we check 0 <= c <= cap (A), then 0 <= b <= c (B), then 0 <= a <= b (C), we want the
// default registers to match so we don't need to copy registers around unnecessarily. // default registers to match so we don't need to copy registers around unnecessarily.

View File

@ -2207,6 +2207,7 @@ const (
OpMIPS64LoweredGetCallerSP OpMIPS64LoweredGetCallerSP
OpMIPS64LoweredGetCallerPC OpMIPS64LoweredGetCallerPC
OpMIPS64LoweredWB OpMIPS64LoweredWB
OpMIPS64LoweredPubBarrier
OpMIPS64LoweredPanicBoundsA OpMIPS64LoweredPanicBoundsA
OpMIPS64LoweredPanicBoundsB OpMIPS64LoweredPanicBoundsB
OpMIPS64LoweredPanicBoundsC OpMIPS64LoweredPanicBoundsC
@ -29755,6 +29756,13 @@ var opcodeTable = [...]opInfo{
}, },
}, },
}, },
{
name: "LoweredPubBarrier",
argLen: 1,
hasSideEffects: true,
asm: mips.ASYNC,
reg: regInfo{},
},
{ {
name: "LoweredPanicBoundsA", name: "LoweredPanicBoundsA",
auxType: auxInt64, auxType: auxInt64,

View File

@ -502,6 +502,9 @@ func rewriteValueMIPS64(v *Value) bool {
return true return true
case OpPanicBounds: case OpPanicBounds:
return rewriteValueMIPS64_OpPanicBounds(v) return rewriteValueMIPS64_OpPanicBounds(v)
case OpPubBarrier:
v.Op = OpMIPS64LoweredPubBarrier
return true
case OpRotateLeft16: case OpRotateLeft16:
return rewriteValueMIPS64_OpRotateLeft16(v) return rewriteValueMIPS64_OpRotateLeft16(v)
case OpRotateLeft32: case OpRotateLeft32:

View File

@ -163,7 +163,7 @@ func initIntrinsics(cfg *intrinsicBuildConfig) {
s.vars[memVar] = s.newValue1(ssa.OpPubBarrier, types.TypeMem, s.mem()) s.vars[memVar] = s.newValue1(ssa.OpPubBarrier, types.TypeMem, s.mem())
return nil return nil
}, },
sys.ARM64, sys.Loong64, sys.PPC64, sys.RISCV64) sys.ARM64, sys.Loong64, sys.MIPS64, sys.PPC64, sys.RISCV64)
/******** internal/runtime/sys ********/ /******** internal/runtime/sys ********/
add("internal/runtime/sys", "GetCallerPC", add("internal/runtime/sys", "GetCallerPC",

View File

@ -631,6 +631,7 @@ var wantIntrinsics = map[testIntrinsicKey]struct{}{
{"mips64", "math/bits", "Sub"}: struct{}{}, {"mips64", "math/bits", "Sub"}: struct{}{},
{"mips64", "math/bits", "Sub64"}: struct{}{}, {"mips64", "math/bits", "Sub64"}: struct{}{},
{"mips64", "runtime", "KeepAlive"}: struct{}{}, {"mips64", "runtime", "KeepAlive"}: struct{}{},
{"mips64", "runtime", "publicationBarrier"}: struct{}{},
{"mips64", "runtime", "slicebytetostringtmp"}: struct{}{}, {"mips64", "runtime", "slicebytetostringtmp"}: struct{}{},
{"mips64", "sync", "runtime_LoadAcquintptr"}: struct{}{}, {"mips64", "sync", "runtime_LoadAcquintptr"}: struct{}{},
{"mips64", "sync", "runtime_StoreReluintptr"}: struct{}{}, {"mips64", "sync", "runtime_StoreReluintptr"}: struct{}{},
@ -718,6 +719,7 @@ var wantIntrinsics = map[testIntrinsicKey]struct{}{
{"mips64le", "math/bits", "Sub"}: struct{}{}, {"mips64le", "math/bits", "Sub"}: struct{}{},
{"mips64le", "math/bits", "Sub64"}: struct{}{}, {"mips64le", "math/bits", "Sub64"}: struct{}{},
{"mips64le", "runtime", "KeepAlive"}: struct{}{}, {"mips64le", "runtime", "KeepAlive"}: struct{}{},
{"mips64le", "runtime", "publicationBarrier"}: struct{}{},
{"mips64le", "runtime", "slicebytetostringtmp"}: struct{}{}, {"mips64le", "runtime", "slicebytetostringtmp"}: struct{}{},
{"mips64le", "sync", "runtime_LoadAcquintptr"}: struct{}{}, {"mips64le", "sync", "runtime_LoadAcquintptr"}: struct{}{},
{"mips64le", "sync", "runtime_StoreReluintptr"}: struct{}{}, {"mips64le", "sync", "runtime_StoreReluintptr"}: struct{}{},