From 93a3566fcb9ab378457a55ea062ccb87d663d5b2 Mon Sep 17 00:00:00 2001 From: Rebecca Stambler Date: Fri, 4 Sep 2020 00:53:27 -0400 Subject: [PATCH] internal/lsp/cache: don't set an error by default in load Change-Id: Icd4495a37f6a3a2eb148d9a1b1949e3741cdd966 Reviewed-on: https://go-review.googlesource.com/c/tools/+/252980 Reviewed-by: Heschi Kreinick --- internal/lsp/cache/load.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/internal/lsp/cache/load.go b/internal/lsp/cache/load.go index 27bfbc8221..4b93bbad8a 100644 --- a/internal/lsp/cache/load.go +++ b/internal/lsp/cache/load.go @@ -121,10 +121,12 @@ func (s *snapshot) load(ctx context.Context, scopes ...interface{}) error { } event.Error(ctx, "go/packages.Load", err, tag.Snapshot.Of(s.ID()), tag.Directory.Of(cfg.Dir), tag.Query.Of(query), tag.PackageCount.Of(len(pkgs))) } else { - err = fmt.Errorf("no packages returned") event.Log(ctx, "go/packages.Load", tag.Snapshot.Of(s.ID()), tag.Directory.Of(cfg.Dir), tag.Query.Of(query), tag.PackageCount.Of(len(pkgs))) } if len(pkgs) == 0 { + if err == nil { + err = fmt.Errorf("no packages returned") + } return errors.Errorf("%v: %w", err, source.PackagesLoadError) }