mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

runtime: guard against runtime/sema* ops on Darwin signal stack. 

These operations misbehave and cause hangs and flakes.
Fail hard if they are attempted.

Tested by backing out the Darwin-profiling-hang fix
CL 518836 and running run.bash, the guard panicked in
runtime/pprof tests, as expected/hoped.

Updates #61768

Change-Id: I89b6f85745fbaa2245141ea98f584afc5d6b133e
Reviewed-on: https://go-review.googlesource.com/c/go/+/519275
Reviewed-by: Austin Clements <austin@google.com>
Run-TryBot: David Chase <drchase@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
This commit is contained in:
David Chase 2023-08-14 13:20:45 -04:00
parent 0e9bf41e1d
commit 91bea5a21d
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/runtime/os_darwin.go
View File

@ -41,7 +41,12 @@ func semasleep(ns int64) int32 {
if ns >= 0 {
start = nanotime()
}
mp := getg().m
g := getg()
mp := g.m
if g == mp.gsignal {
// sema sleep/wakeup are implemented with pthreads, which are not async-signal-safe on Darwin.
throw("semasleep on Darwin signal stack")
}
pthread_mutex_lock(&mp.mutex)
for {
if mp.count > 0 {
@ -70,6 +75,9 @@ func semasleep(ns int64) int32 {
//go:nosplit
func semawakeup(mp *m) {
if g := getg(); g == g.m.gsignal {
throw("semawakeup on Darwin signal stack")
}
pthread_mutex_lock(&mp.mutex)
mp.count++
if mp.count > 0 {