From 8facea2ecf42791db365a9fda7ae99f3bbf11b06 Mon Sep 17 00:00:00 2001 From: Rebecca Stambler Date: Thu, 12 Dec 2019 11:53:53 -0500 Subject: [PATCH] go/packages: disable -mod=readonly behavior in overlays This was preventing mod files from being updated when dependencies were added to overlays. This prevents gopls from accurately modifying a user's mod file when a dependency is added, which poses problems for usability. To handle the issues that this was (supposedly) solving, we can require that files from multiple modules are never added in an overlay. For some reason, this doesn't break TestOverlayModFileChanges. Change-Id: I24d6c30754c2bebc440802f7cf2931d98e450ebf Reviewed-on: https://go-review.googlesource.com/c/tools/+/211058 Run-TryBot: Rebecca Stambler TryBot-Result: Gobot Gobot Reviewed-by: Michael Matloob --- go/packages/golist.go | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/go/packages/golist.go b/go/packages/golist.go index a6bdf00eed..9c895b3895 100644 --- a/go/packages/golist.go +++ b/go/packages/golist.go @@ -253,12 +253,7 @@ func addNeededOverlayPackages(cfg *Config, driver driver, response *responseDedu if len(pkgs) == 0 { return nil } - drivercfg := *cfg - if getGoInfo().env.modulesOn { - drivercfg.BuildFlags = append(drivercfg.BuildFlags, "-mod=readonly") - } - dr, err := driver(&drivercfg, pkgs...) - + dr, err := driver(cfg, pkgs...) if err != nil { return err }