mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

cmd/gc: complain about invalid whitespace chars 

Fixes #4405.

R=rsc, bradfitz
CC=golang-dev
https://golang.org/cl/6855060
This commit is contained in:
Robert Griesemer 2012-11-19 09:09:04 -08:00
parent c8e7469fcd
commit 8f3b703323
2 changed files with 17 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/cmd/gc/lex.c
View File

@ -99,7 +99,7 @@ yy_isdigit(int c)
static int
yy_isspace(int c)
{
return c >= 0 && c <= 0xFF && isspace(c);
return c == ' ' || c == '\t' || c == '\n' || c == '\r';
}
static int
@ -790,12 +790,8 @@ static int
isfrog(int c)
{
// complain about possibly invisible control characters
if(c < 0)
return 1;
if(c < ' ') {
if(c == '\n' || c== '\r' || c == '\t') // good white space
return 0;
return 1;
return !yy_isspace(c); // exclude good white space
}
if(0x7f <= c && c <= 0xa0) // DEL, unicode block including unbreakable space.
return 1;

15
test/fixedbugs/issue4405.go Normal file
View File

@ -0,0 +1,15 @@
// errorcheck
// Copyright 2012 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
package p
const (
_ = iota
_ // ERROR "illegal character"
_ // ERROR "illegal character"
_ // ERROR "illegal character"
_ // ERROR "illegal character"
)