From 8c830569a8eabb55cf0049da6df43fab638c5c53 Mon Sep 17 00:00:00 2001 From: Robert Findley Date: Mon, 15 Aug 2022 14:24:47 -0400 Subject: [PATCH] gopls/internal/regtest: unskip TestSumUpdateFixesDiagnostics Metadata reloading has been significantly refactored recently. Unskip this test to see if it still flakes. For golang/go#51352 For golang/go#53878 Change-Id: I9f2ae1835bbace1b5095c2d45db082c4e709437b Reviewed-on: https://go-review.googlesource.com/c/tools/+/423974 Run-TryBot: Robert Findley TryBot-Result: Gopher Robot gopls-CI: kokoro Reviewed-by: Peter Weinberger --- gopls/internal/regtest/modfile/modfile_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/gopls/internal/regtest/modfile/modfile_test.go b/gopls/internal/regtest/modfile/modfile_test.go index a32a06a32f..8dabc43f6a 100644 --- a/gopls/internal/regtest/modfile/modfile_test.go +++ b/gopls/internal/regtest/modfile/modfile_test.go @@ -877,8 +877,6 @@ func main() {} } func TestSumUpdateFixesDiagnostics(t *testing.T) { - t.Skipf("Skipping known-flaky test; see https://go.dev/issue/51352.") - testenv.NeedsGo1Point(t, 14) const mod = `