From 884ffcdf166f9ee4133a974a6f996d551c8a8bbb Mon Sep 17 00:00:00 2001 From: Xiaodong Liu Date: Fri, 15 Oct 2021 14:21:45 +0800 Subject: [PATCH] go/analysis: add support for loong64 On loong64 stack pointer register (SP) is R3 and link register is R1. Updates golang/go#46229 Co-authored-by: Meidan Li Change-Id: I5a47e53846a24934f786655dbe2c2b164aece5c4 Reviewed-on: https://go-review.googlesource.com/c/tools/+/356089 Run-TryBot: Ian Lance Taylor gopls-CI: kokoro TryBot-Result: Gopher Robot Reviewed-by: Ian Lance Taylor Reviewed-by: Dmitri Shuralyov --- go/analysis/passes/asmdecl/asmdecl.go | 4 +- go/analysis/passes/asmdecl/asmdecl_test.go | 8 +- .../passes/asmdecl/testdata/src/a/asm10.s | 192 ++++++++++++++++++ 3 files changed, 200 insertions(+), 4 deletions(-) create mode 100644 go/analysis/passes/asmdecl/testdata/src/a/asm10.s diff --git a/go/analysis/passes/asmdecl/asmdecl.go b/go/analysis/passes/asmdecl/asmdecl.go index b05ed5c157..e88a81f9ce 100644 --- a/go/analysis/passes/asmdecl/asmdecl.go +++ b/go/analysis/passes/asmdecl/asmdecl.go @@ -86,6 +86,7 @@ var ( asmArchArm = asmArch{name: "arm", bigEndian: false, stack: "R13", lr: true} asmArchArm64 = asmArch{name: "arm64", bigEndian: false, stack: "RSP", lr: true, retRegs: []string{"R0", "F0"}} asmArchAmd64 = asmArch{name: "amd64", bigEndian: false, stack: "SP", lr: false, retRegs: []string{"AX", "X0"}} + asmArchLoong64 = asmArch{name: "loong64", bigEndian: false, stack: "R3", lr: true} asmArchMips = asmArch{name: "mips", bigEndian: true, stack: "R29", lr: true} asmArchMipsLE = asmArch{name: "mipsle", bigEndian: false, stack: "R29", lr: true} asmArchMips64 = asmArch{name: "mips64", bigEndian: true, stack: "R29", lr: true} @@ -101,6 +102,7 @@ var ( &asmArchArm, &asmArchArm64, &asmArchAmd64, + &asmArchLoong64, &asmArchMips, &asmArchMipsLE, &asmArchMips64, @@ -731,7 +733,7 @@ func asmCheckVar(badf func(string, ...interface{}), fn *asmFunc, line, expr stri src = 8 } } - case "mips", "mipsle", "mips64", "mips64le": + case "loong64", "mips", "mipsle", "mips64", "mips64le": switch op { case "MOVB", "MOVBU": src = 1 diff --git a/go/analysis/passes/asmdecl/asmdecl_test.go b/go/analysis/passes/asmdecl/asmdecl_test.go index f88c188b25..f6b01a9c30 100644 --- a/go/analysis/passes/asmdecl/asmdecl_test.go +++ b/go/analysis/passes/asmdecl/asmdecl_test.go @@ -14,9 +14,11 @@ import ( ) var goosarches = []string{ - "linux/amd64", // asm1.s, asm4.s - "linux/386", // asm2.s - "linux/arm", // asm3.s + "linux/amd64", // asm1.s, asm4.s + "linux/386", // asm2.s + "linux/arm", // asm3.s + // TODO: skip test on loong64 until go toolchain supported loong64. + // "linux/loong64", // asm10.s "linux/mips64", // asm5.s "linux/s390x", // asm6.s "linux/ppc64", // asm7.s diff --git a/go/analysis/passes/asmdecl/testdata/src/a/asm10.s b/go/analysis/passes/asmdecl/testdata/src/a/asm10.s new file mode 100644 index 0000000000..f0045882a8 --- /dev/null +++ b/go/analysis/passes/asmdecl/testdata/src/a/asm10.s @@ -0,0 +1,192 @@ +// Copyright 2022 The Go Authors. All rights reserved. +// Use of this source code is governed by a BSD-style +// license that can be found in the LICENSE file. + +//go:build loong64 + +TEXT ·arg1(SB),0,$0-2 + MOVB x+0(FP), R19 + MOVBU y+1(FP), R18 + MOVH x+0(FP), R19 // want `\[loong64\] arg1: invalid MOVH of x\+0\(FP\); int8 is 1-byte value` + MOVHU y+1(FP), R19 // want `invalid MOVHU of y\+1\(FP\); uint8 is 1-byte value` + MOVW x+0(FP), R19 // want `invalid MOVW of x\+0\(FP\); int8 is 1-byte value` + MOVWU y+1(FP), R19 // want `invalid MOVWU of y\+1\(FP\); uint8 is 1-byte value` + MOVV x+0(FP), R19 // want `invalid MOVV of x\+0\(FP\); int8 is 1-byte value` + MOVV y+1(FP), R19 // want `invalid MOVV of y\+1\(FP\); uint8 is 1-byte value` + MOVB x+1(FP), R19 // want `invalid offset x\+1\(FP\); expected x\+0\(FP\)` + MOVBU y+2(FP), R19 // want `invalid offset y\+2\(FP\); expected y\+1\(FP\)` + MOVB 16(R3), R19 // want `16\(R3\) should be x\+0\(FP\)` + MOVB 17(R3), R19 // want `17\(R3\) should be y\+1\(FP\)` + MOVB 18(R3), R19 // want `use of 18\(R3\) points beyond argument frame` + RET + +TEXT ·arg2(SB),0,$0-4 + MOVBU x+0(FP), R19 // want `arg2: invalid MOVBU of x\+0\(FP\); int16 is 2-byte value` + MOVB y+2(FP), R19 // want `invalid MOVB of y\+2\(FP\); uint16 is 2-byte value` + MOVHU x+0(FP), R19 + MOVH y+2(FP), R18 + MOVWU x+0(FP), R19 // want `invalid MOVWU of x\+0\(FP\); int16 is 2-byte value` + MOVW y+2(FP), R19 // want `invalid MOVW of y\+2\(FP\); uint16 is 2-byte value` + MOVV x+0(FP), R19 // want `invalid MOVV of x\+0\(FP\); int16 is 2-byte value` + MOVV y+2(FP), R19 // want `invalid MOVV of y\+2\(FP\); uint16 is 2-byte value` + MOVHU x+2(FP), R19 // want `invalid offset x\+2\(FP\); expected x\+0\(FP\)` + MOVH y+0(FP), R19 // want `invalid offset y\+0\(FP\); expected y\+2\(FP\)` + RET + +TEXT ·arg4(SB),0,$0-2 // want `arg4: wrong argument size 2; expected \$\.\.\.-8` + MOVB x+0(FP), R19 // want `invalid MOVB of x\+0\(FP\); int32 is 4-byte value` + MOVB y+4(FP), R18 // want `invalid MOVB of y\+4\(FP\); uint32 is 4-byte value` + MOVH x+0(FP), R19 // want `invalid MOVH of x\+0\(FP\); int32 is 4-byte value` + MOVH y+4(FP), R19 // want `invalid MOVH of y\+4\(FP\); uint32 is 4-byte value` + MOVW x+0(FP), R19 + MOVW y+4(FP), R19 + MOVV x+0(FP), R19 // want `invalid MOVV of x\+0\(FP\); int32 is 4-byte value` + MOVV y+4(FP), R19 // want `invalid MOVV of y\+4\(FP\); uint32 is 4-byte value` + MOVW x+4(FP), R19 // want `invalid offset x\+4\(FP\); expected x\+0\(FP\)` + MOVW y+2(FP), R19 // want `invalid offset y\+2\(FP\); expected y\+4\(FP\)` + RET + +TEXT ·arg8(SB),7,$0-2 // want `wrong argument size 2; expected \$\.\.\.-16` + MOVB x+0(FP), R19 // want `invalid MOVB of x\+0\(FP\); int64 is 8-byte value` + MOVB y+8(FP), R18 // want `invalid MOVB of y\+8\(FP\); uint64 is 8-byte value` + MOVH x+0(FP), R19 // want `invalid MOVH of x\+0\(FP\); int64 is 8-byte value` + MOVH y+8(FP), R19 // want `invalid MOVH of y\+8\(FP\); uint64 is 8-byte value` + MOVW x+0(FP), R19 // want `invalid MOVW of x\+0\(FP\); int64 is 8-byte value` + MOVW y+8(FP), R19 // want `invalid MOVW of y\+8\(FP\); uint64 is 8-byte value` + MOVV x+0(FP), R19 + MOVV y+8(FP), R19 + MOVV x+8(FP), R19 // want `invalid offset x\+8\(FP\); expected x\+0\(FP\)` + MOVV y+2(FP), R19 // want `invalid offset y\+2\(FP\); expected y\+8\(FP\)` + RET + +TEXT ·argint(SB),0,$0-2 // want `wrong argument size 2; expected \$\.\.\.-16` + MOVB x+0(FP), R19 // want `invalid MOVB of x\+0\(FP\); int is 8-byte value` + MOVB y+8(FP), R18 // want `invalid MOVB of y\+8\(FP\); uint is 8-byte value` + MOVH x+0(FP), R19 // want `invalid MOVH of x\+0\(FP\); int is 8-byte value` + MOVH y+8(FP), R19 // want `invalid MOVH of y\+8\(FP\); uint is 8-byte value` + MOVW x+0(FP), R19 // want `invalid MOVW of x\+0\(FP\); int is 8-byte value` + MOVW y+8(FP), R19 // want `invalid MOVW of y\+8\(FP\); uint is 8-byte value` + MOVV x+0(FP), R19 + MOVV y+8(FP), R19 + MOVV x+8(FP), R19 // want `invalid offset x\+8\(FP\); expected x\+0\(FP\)` + MOVV y+2(FP), R19 // want `invalid offset y\+2\(FP\); expected y\+8\(FP\)` + RET + +TEXT ·argptr(SB),7,$0-2 // want `wrong argument size 2; expected \$\.\.\.-40` + MOVB x+0(FP), R19 // want `invalid MOVB of x\+0\(FP\); \*byte is 8-byte value` + MOVB y+8(FP), R18 // want `invalid MOVB of y\+8\(FP\); \*byte is 8-byte value` + MOVH x+0(FP), R19 // want `invalid MOVH of x\+0\(FP\); \*byte is 8-byte value` + MOVH y+8(FP), R19 // want `invalid MOVH of y\+8\(FP\); \*byte is 8-byte value` + MOVW x+0(FP), R19 // want `invalid MOVW of x\+0\(FP\); \*byte is 8-byte value` + MOVW y+8(FP), R19 // want `invalid MOVW of y\+8\(FP\); \*byte is 8-byte value` + MOVV x+0(FP), R19 + MOVV y+8(FP), R19 + MOVV x+8(FP), R19 // want `invalid offset x\+8\(FP\); expected x\+0\(FP\)` + MOVV y+2(FP), R19 // want `invalid offset y\+2\(FP\); expected y\+8\(FP\)` + MOVW c+16(FP), R19 // want `invalid MOVW of c\+16\(FP\); chan int is 8-byte value` + MOVW m+24(FP), R19 // want `invalid MOVW of m\+24\(FP\); map\[int\]int is 8-byte value` + MOVW f+32(FP), R19 // want `invalid MOVW of f\+32\(FP\); func\(\) is 8-byte value` + RET + +TEXT ·argstring(SB),0,$32 // want `wrong argument size 0; expected \$\.\.\.-32` + MOVH x+0(FP), R19 // want `invalid MOVH of x\+0\(FP\); string base is 8-byte value` + MOVW x+0(FP), R19 // want `invalid MOVW of x\+0\(FP\); string base is 8-byte value` + MOVV x+0(FP), R19 + MOVH x_base+0(FP), R19 // want `invalid MOVH of x_base\+0\(FP\); string base is 8-byte value` + MOVW x_base+0(FP), R19 // want `invalid MOVW of x_base\+0\(FP\); string base is 8-byte value` + MOVV x_base+0(FP), R19 + MOVH x_len+0(FP), R19 // want `invalid offset x_len\+0\(FP\); expected x_len\+8\(FP\)` + MOVW x_len+0(FP), R19 // want `invalid offset x_len\+0\(FP\); expected x_len\+8\(FP\)` + MOVV x_len+0(FP), R19 // want `invalid offset x_len\+0\(FP\); expected x_len\+8\(FP\)` + MOVH x_len+8(FP), R19 // want `invalid MOVH of x_len\+8\(FP\); string len is 8-byte value` + MOVW x_len+8(FP), R19 // want `invalid MOVW of x_len\+8\(FP\); string len is 8-byte value` + MOVV x_len+8(FP), R19 + MOVV y+0(FP), R19 // want `invalid offset y\+0\(FP\); expected y\+16\(FP\)` + MOVV y_len+8(FP), R19 // want `invalid offset y_len\+8\(FP\); expected y_len\+24\(FP\)` + RET + +TEXT ·argslice(SB),0,$48 // want `wrong argument size 0; expected \$\.\.\.-48` + MOVH x+0(FP), R19 // want `invalid MOVH of x\+0\(FP\); slice base is 8-byte value` + MOVW x+0(FP), R19 // want `invalid MOVW of x\+0\(FP\); slice base is 8-byte value` + MOVV x+0(FP), R19 + MOVH x_base+0(FP), R19 // want `invalid MOVH of x_base\+0\(FP\); slice base is 8-byte value` + MOVW x_base+0(FP), R19 // want `invalid MOVW of x_base\+0\(FP\); slice base is 8-byte value` + MOVV x_base+0(FP), R19 + MOVH x_len+0(FP), R19 // want `invalid offset x_len\+0\(FP\); expected x_len\+8\(FP\)` + MOVW x_len+0(FP), R19 // want `invalid offset x_len\+0\(FP\); expected x_len\+8\(FP\)` + MOVV x_len+0(FP), R19 // want `invalid offset x_len\+0\(FP\); expected x_len\+8\(FP\)` + MOVH x_len+8(FP), R19 // want `invalid MOVH of x_len\+8\(FP\); slice len is 8-byte value` + MOVW x_len+8(FP), R19 // want `invalid MOVW of x_len\+8\(FP\); slice len is 8-byte value` + MOVV x_len+8(FP), R19 + MOVH x_cap+0(FP), R19 // want `invalid offset x_cap\+0\(FP\); expected x_cap\+16\(FP\)` + MOVW x_cap+0(FP), R19 // want `invalid offset x_cap\+0\(FP\); expected x_cap\+16\(FP\)` + MOVV x_cap+0(FP), R19 // want `invalid offset x_cap\+0\(FP\); expected x_cap\+16\(FP\)` + MOVH x_cap+16(FP), R19 // want `invalid MOVH of x_cap\+16\(FP\); slice cap is 8-byte value` + MOVW x_cap+16(FP), R19 // want `invalid MOVW of x_cap\+16\(FP\); slice cap is 8-byte value` + MOVV x_cap+16(FP), R19 + MOVV y+0(FP), R19 // want `invalid offset y\+0\(FP\); expected y\+24\(FP\)` + MOVV y_len+8(FP), R19 // want `invalid offset y_len\+8\(FP\); expected y_len\+32\(FP\)` + MOVV y_cap+16(FP), R19 // want `invalid offset y_cap\+16\(FP\); expected y_cap\+40\(FP\)` + RET + +TEXT ·argiface(SB),0,$0-32 + MOVH x+0(FP), R19 // want `invalid MOVH of x\+0\(FP\); interface type is 8-byte value` + MOVW x+0(FP), R19 // want `invalid MOVW of x\+0\(FP\); interface type is 8-byte value` + MOVV x+0(FP), R19 + MOVH x_type+0(FP), R19 // want `invalid MOVH of x_type\+0\(FP\); interface type is 8-byte value` + MOVW x_type+0(FP), R19 // want `invalid MOVW of x_type\+0\(FP\); interface type is 8-byte value` + MOVV x_type+0(FP), R19 + MOVV x_itable+0(FP), R19 // want `unknown variable x_itable; offset 0 is x_type\+0\(FP\)` + MOVV x_itable+1(FP), R19 // want `unknown variable x_itable; offset 1 is x_type\+0\(FP\)` + MOVH x_data+0(FP), R19 // want `invalid offset x_data\+0\(FP\); expected x_data\+8\(FP\)` + MOVW x_data+0(FP), R19 // want `invalid offset x_data\+0\(FP\); expected x_data\+8\(FP\)` + MOVV x_data+0(FP), R19 // want `invalid offset x_data\+0\(FP\); expected x_data\+8\(FP\)` + MOVH x_data+8(FP), R19 // want `invalid MOVH of x_data\+8\(FP\); interface data is 8-byte value` + MOVW x_data+8(FP), R19 // want `invalid MOVW of x_data\+8\(FP\); interface data is 8-byte value` + MOVV x_data+8(FP), R19 + MOVH y+16(FP), R19 // want `invalid MOVH of y\+16\(FP\); interface itable is 8-byte value` + MOVW y+16(FP), R19 // want `invalid MOVW of y\+16\(FP\); interface itable is 8-byte value` + MOVV y+16(FP), R19 + MOVH y_itable+16(FP), R19 // want `invalid MOVH of y_itable\+16\(FP\); interface itable is 8-byte value` + MOVW y_itable+16(FP), R19 // want `invalid MOVW of y_itable\+16\(FP\); interface itable is 8-byte value` + MOVV y_itable+16(FP), R19 + MOVV y_type+16(FP), R19 // want `unknown variable y_type; offset 16 is y_itable\+16\(FP\)` + MOVH y_data+16(FP), R19 // want `invalid offset y_data\+16\(FP\); expected y_data\+24\(FP\)` + MOVW y_data+16(FP), R19 // want `invalid offset y_data\+16\(FP\); expected y_data\+24\(FP\)` + MOVV y_data+16(FP), R19 // want `invalid offset y_data\+16\(FP\); expected y_data\+24\(FP\)` + MOVH y_data+24(FP), R19 // want `invalid MOVH of y_data\+24\(FP\); interface data is 8-byte value` + MOVW y_data+24(FP), R19 // want `invalid MOVW of y_data\+24\(FP\); interface data is 8-byte value` + MOVV y_data+24(FP), R19 + RET + +TEXT ·returnint(SB),0,$0-8 + MOVB R19, ret+0(FP) // want `invalid MOVB of ret\+0\(FP\); int is 8-byte value` + MOVH R19, ret+0(FP) // want `invalid MOVH of ret\+0\(FP\); int is 8-byte value` + MOVW R19, ret+0(FP) // want `invalid MOVW of ret\+0\(FP\); int is 8-byte value` + MOVV R19, ret+0(FP) + MOVV R19, ret+1(FP) // want `invalid offset ret\+1\(FP\); expected ret\+0\(FP\)` + MOVV R19, r+0(FP) // want `unknown variable r; offset 0 is ret\+0\(FP\)` + RET + +TEXT ·returnbyte(SB),0,$0-9 + MOVV x+0(FP), R19 + MOVB R19, ret+8(FP) + MOVH R19, ret+8(FP) // want `invalid MOVH of ret\+8\(FP\); byte is 1-byte value` + MOVW R19, ret+8(FP) // want `invalid MOVW of ret\+8\(FP\); byte is 1-byte value` + MOVV R19, ret+8(FP) // want `invalid MOVV of ret\+8\(FP\); byte is 1-byte value` + MOVB R19, ret+7(FP) // want `invalid offset ret\+7\(FP\); expected ret\+8\(FP\)` + RET + +TEXT ·returnnamed(SB),0,$0-41 + MOVB x+0(FP), R19 + MOVV R19, r1+8(FP) + MOVH R19, r2+16(FP) + MOVV R19, r3+24(FP) + MOVV R19, r3_base+24(FP) + MOVV R19, r3_len+32(FP) + MOVB R19, r4+40(FP) + MOVW R19, r1+8(FP) // want `invalid MOVW of r1\+8\(FP\); int is 8-byte value` + RET + +TEXT ·returnintmissing(SB),0,$0-8 + RET // want `RET without writing to 8-byte ret\+0\(FP\)`