From 7e51fbd4c416938b4e68e04220e3d47bf6ec33d2 Mon Sep 17 00:00:00 2001 From: Rob Findley Date: Wed, 20 Jan 2021 10:55:44 -0500 Subject: [PATCH] gopls/internal/regtest: re-enable android builder Remove the exception for the Android amd64 builder, now that flakes are fixed (though the exception didn't actually work anyway due to golang/go#39460). Also, accept the import reorganization applied by gopls. Fixes golang/go#43554 Change-Id: I9a7cce35998cfa673699d74a487111e4daecf7ec Reviewed-on: https://go-review.googlesource.com/c/tools/+/284935 Trust: Robert Findley Run-TryBot: Robert Findley gopls-CI: kokoro TryBot-Result: Go Bot Reviewed-by: Rebecca Stambler --- gopls/internal/regtest/runner.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gopls/internal/regtest/runner.go b/gopls/internal/regtest/runner.go index 1e77cb8ef3..3348040caa 100644 --- a/gopls/internal/regtest/runner.go +++ b/gopls/internal/regtest/runner.go @@ -8,7 +8,6 @@ import ( "bytes" "context" "fmt" - exec "golang.org/x/sys/execabs" "io" "io/ioutil" "net" @@ -20,6 +19,8 @@ import ( "testing" "time" + exec "golang.org/x/sys/execabs" + "golang.org/x/tools/gopls/internal/hooks" "golang.org/x/tools/internal/jsonrpc2" "golang.org/x/tools/internal/jsonrpc2/servertest" @@ -308,7 +309,6 @@ var longBuilders = map[string]string{ "netbsd-arm-bsiegert": "", "solaris-amd64-oraclerel": "", "windows-arm-zx2c4": "", - "android-amd64-emu": "golang.org/issue/43554", } func checkBuilder(t *testing.T) {