From 7736277c76ecb18da89f4d073ddc1da3b2e150c9 Mon Sep 17 00:00:00 2001 From: Rebecca Stambler Date: Mon, 27 Jan 2020 16:26:00 -0500 Subject: [PATCH] internal/lsp: remove shadow analysis from default suite Mostly because I find it very annoying. But I imagine lots of people shadow variables intentionally, and it's very noisy. Also, fix an error caught by the nilness check while I'm thinkng about analyses. Change-Id: I1867c8613194028815666efd879899bb5065c9d7 Reviewed-on: https://go-review.googlesource.com/c/tools/+/216541 Run-TryBot: Rebecca Stambler Reviewed-by: Michael Matloob TryBot-Result: Gobot Gobot --- internal/lsp/cache/view.go | 3 --- internal/lsp/source/options.go | 2 -- 2 files changed, 5 deletions(-) diff --git a/internal/lsp/cache/view.go b/internal/lsp/cache/view.go index 10b428383f..a56a9deec0 100644 --- a/internal/lsp/cache/view.go +++ b/internal/lsp/cache/view.go @@ -247,9 +247,6 @@ func (v *view) buildBuiltinPackage(ctx context.Context, m *metadata) error { data.pkg, data.err = ast.NewPackage(fset, map[string]*ast.File{ pgh.File().Identity().URI.Filename(): file, }, nil, nil) - if err != nil { - return err - } return data }) v.builtin = &builtinPackageHandle{ diff --git a/internal/lsp/source/options.go b/internal/lsp/source/options.go index 6b8b52c89c..fc3c7b4a8f 100644 --- a/internal/lsp/source/options.go +++ b/internal/lsp/source/options.go @@ -28,7 +28,6 @@ import ( "golang.org/x/tools/go/analysis/passes/nilfunc" "golang.org/x/tools/go/analysis/passes/nilness" "golang.org/x/tools/go/analysis/passes/printf" - "golang.org/x/tools/go/analysis/passes/shadow" "golang.org/x/tools/go/analysis/passes/shift" "golang.org/x/tools/go/analysis/passes/sortslice" "golang.org/x/tools/go/analysis/passes/stdmethods" @@ -495,7 +494,6 @@ var defaultAnalyzers = map[string]*analysis.Analyzer{ // Non-vet analyzers deepequalerrors.Analyzer.Name: deepequalerrors.Analyzer, nilness.Analyzer.Name: nilness.Analyzer, - shadow.Analyzer.Name: shadow.Analyzer, sortslice.Analyzer.Name: sortslice.Analyzer, testinggoroutine.Analyzer.Name: testinggoroutine.Analyzer, }