From 771dabf43312a29ffd9f1e7c9ed862c82c9bbf5e Mon Sep 17 00:00:00 2001 From: "Bryan C. Mills" Date: Wed, 17 Nov 2021 11:41:19 -0500 Subject: [PATCH] gopls/internal/regtest/misc: skip TestInconsistentVendoring on Windows This test is probably detecting a real bug that exclusively affects Windows. To avoid masking other bugs, let's skip the test on that platform until the bug is fixed. For golang/go#49646 Change-Id: I38c615d47454ecfd72b416fff2018973b3ae9259 Reviewed-on: https://go-review.googlesource.com/c/tools/+/364676 Trust: Bryan C. Mills Run-TryBot: Bryan C. Mills gopls-CI: kokoro TryBot-Result: Go Bot Reviewed-by: Robert Findley --- gopls/internal/regtest/misc/vendor_test.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gopls/internal/regtest/misc/vendor_test.go b/gopls/internal/regtest/misc/vendor_test.go index 4e02799b47..0e615f2818 100644 --- a/gopls/internal/regtest/misc/vendor_test.go +++ b/gopls/internal/regtest/misc/vendor_test.go @@ -5,6 +5,7 @@ package misc import ( + "runtime" "testing" . "golang.org/x/tools/internal/lsp/regtest" @@ -26,6 +27,9 @@ var Goodbye error func TestInconsistentVendoring(t *testing.T) { testenv.NeedsGo1Point(t, 14) + if runtime.GOOS == "windows" { + t.Skipf("skipping test due to flakiness on Windows: https://golang.org/issue/49646") + } const pkgThatUsesVendoring = ` -- go.mod --