From 726034ecff01c8e68f8fb97fbf037417e7542f40 Mon Sep 17 00:00:00 2001 From: Rebecca Stambler Date: Wed, 2 Jun 2021 18:11:56 +0000 Subject: [PATCH] Revert "internal/lsp: enable semantic tokens by default" This reverts commit 5ab822f631a3f7b79c55b1e1dd18978ed2fcc312. Reason for revert: Too early to enable since we need to figure out a plan for formatting directives Change-Id: I46567b271d4ecd7e4af574221520a72bd8b8e500 Reviewed-on: https://go-review.googlesource.com/c/tools/+/324289 Trust: Rebecca Stambler Run-TryBot: Rebecca Stambler Reviewed-by: Hyang-Ah Hana Kim Reviewed-by: Peter Weinberger gopls-CI: kokoro TryBot-Result: Go Bot --- gopls/doc/settings.md | 2 +- internal/lsp/source/api_json.go | 2 +- internal/lsp/source/options.go | 1 - 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/gopls/doc/settings.md b/gopls/doc/settings.md index 4684d0da9c..c04ab05dd9 100644 --- a/gopls/doc/settings.md +++ b/gopls/doc/settings.md @@ -213,7 +213,7 @@ Default: `{"gc_details":false,"generate":true,"regenerate_cgo":true,"tidy":true, semanticTokens controls whether the LSP server will send semantic tokens to the client. -Default: `true`. +Default: `false`. #### Completion diff --git a/internal/lsp/source/api_json.go b/internal/lsp/source/api_json.go index 17eb3ecf4a..80171929c1 100755 --- a/internal/lsp/source/api_json.go +++ b/internal/lsp/source/api_json.go @@ -697,7 +697,7 @@ var GeneratedAPIJSON = &APIJSON{ Keys: nil, }, EnumValues: nil, - Default: "true", + Default: "false", Status: "experimental", Hierarchy: "ui", }, diff --git a/internal/lsp/source/options.go b/internal/lsp/source/options.go index 613ce82cc5..1f81c9eb37 100644 --- a/internal/lsp/source/options.go +++ b/internal/lsp/source/options.go @@ -143,7 +143,6 @@ func DefaultOptions() *Options { string(command.UpgradeDependency): true, string(command.Vendor): true, }, - SemanticTokens: true, }, }, InternalOptions: InternalOptions{