From 6f99366264eeb34bcbb93c55e38f2acfb3358d51 Mon Sep 17 00:00:00 2001 From: Alan Donovan Date: Thu, 10 Nov 2022 15:07:47 -0500 Subject: [PATCH] gopls/internal/lsp/cache: don't pass snapshot.fset to go/packages ...since we do our own parsing. Change-Id: Id762cca408692b9535b8bb36017d6719180e5bb1 Reviewed-on: https://go-review.googlesource.com/c/tools/+/449498 Run-TryBot: Alan Donovan TryBot-Result: Gopher Robot Reviewed-by: Robert Findley Auto-Submit: Alan Donovan gopls-CI: kokoro --- gopls/internal/lsp/cache/snapshot.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gopls/internal/lsp/cache/snapshot.go b/gopls/internal/lsp/cache/snapshot.go index b05f401c52..d6599b1cee 100644 --- a/gopls/internal/lsp/cache/snapshot.go +++ b/gopls/internal/lsp/cache/snapshot.go @@ -345,7 +345,7 @@ func (s *snapshot) config(ctx context.Context, inv *gocommand.Invocation) *packa packages.NeedModule | packages.LoadMode(packagesinternal.DepsErrors) | packages.LoadMode(packagesinternal.ForTest), - Fset: s.FileSet(), + Fset: nil, // we do our own parsing Overlay: s.buildOverlay(), ParseFile: func(*token.FileSet, string, []byte) (*ast.File, error) { panic("go/packages must not be used to parse files")