mirror of https://github.com/golang/go.git
runtime: fix checkmarks to rescan stacks
Currently checkmarks mode fails to rescan stacks because it sees the leftover state bits indicating that the stacks haven't changed since the last scan. As a result, it won't detect lost marks caused by failing to scan stacks correctly during regular garbage collection. Fix this by marking all stacks dirty before performing the checkmark phase. Change-Id: I1f06882bb8b20257120a4b8e7f95bb3ffc263895 Reviewed-on: https://go-review.googlesource.com/10794 Reviewed-by: Russ Cox <rsc@golang.org>
This commit is contained in:
parent
0599913a85
commit
6f6403eddf
|
|
@ -937,6 +937,7 @@ func gc(mode int) {
|
|||
// Run a full stop-the-world mark using checkmark bits,
|
||||
// to check that we didn't forget to mark anything during
|
||||
// the concurrent mark process.
|
||||
gcResetGState() // Rescan stacks
|
||||
initCheckmarks()
|
||||
gcMark(startTime)
|
||||
clearCheckmarks()
|
||||
|
|
|
|||
Loading…
Reference in New Issue