mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

internal/lsp/cache: keep going on per-file workspace symbol errors 

I'm not sure how to hit this in practice, since it appears that symbols
should only return errors with some type of corruption, but we should
keep going when searching for symbols in snapshot files.

Change-Id: I9fcf6cc92fdc943520e8890ece51d28ec46e8812
Reviewed-on: https://go-review.googlesource.com/c/tools/+/376363
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
Reviewed-by: Peter Weinberger <pjw@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
This commit is contained in:
Robert Findley 2022-01-07 18:12:07 -05:00
parent 21ca3b3a93
commit 6299a6dbc2
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
internal/lsp/cache/snapshot.go vendored
View File

@ -966,15 +966,25 @@ func (s *snapshot) activePackageHandles(ctx context.Context) ([]*packageHandle,
func (s *snapshot) Symbols(ctx context.Context) (map[span.URI][]source.Symbol, error) {
result := make(map[span.URI][]source.Symbol)
// Keep going on errors, but log the first failure. Partial symbol results
// are better than no symbol results.
var firstErr error
for uri, f := range s.files {
sh := s.buildSymbolHandle(ctx, f)
v, err := sh.handle.Get(ctx, s.generation, s)
if err != nil {
return nil, err
if firstErr == nil {
firstErr = err
}
continue
}
data := v.(*symbolData)
result[uri] = data.symbols
}
if firstErr != nil {
event.Error(ctx, "getting snapshot symbols", firstErr)
}
return result, nil
}