mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

image/jpeg, image/png: replace Fatal with Error in tests 

Replaced t.Fatalf with t.Errorf for non-critical errors to footprint more failing test cases for better analysis of the error.

Change-Id: I6f51d21e37a4ddb95d239d8afed2154f3ef52d31
GitHub-Last-Rev: d56aa49bce
GitHub-Pull-Request: golang/go#60524
Reviewed-on: https://go-review.googlesource.com/c/go/+/499336
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Run-TryBot: Ian Lance Taylor <iant@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: David Chase <drchase@google.com>
This commit is contained in:
Hiro 2023-08-01 07:25:46 +00:00 committed by Gopher Robot
parent 8657603731
commit 54a540ffa2
2 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/image/jpeg/fuzz_test.go
View File

@ -49,16 +49,18 @@ func FuzzDecode(f *testing.F) {
var w bytes.Buffer
err := Encode(&w, img, &Options{Quality: q})
if err != nil {
t.Fatalf("failed to encode valid image: %s", err)
t.Errorf("failed to encode valid image: %s", err)
continue
}
img1, err := Decode(&w)
if err != nil {
t.Fatalf("failed to decode roundtripped image: %s", err)
t.Errorf("failed to decode roundtripped image: %s", err)
continue
}
got := img1.Bounds()
want := img.Bounds()
if !got.Eq(want) {
t.Fatalf("roundtripped image bounds have changed, got: %s, want: %s", got, want)
t.Errorf("roundtripped image bounds have changed, got: %s, want: %s", got, want)
}
}
})

8
src/image/png/fuzz_test.go
View File

@ -56,16 +56,18 @@ func FuzzDecode(f *testing.F) {
e := &Encoder{CompressionLevel: l}
err = e.Encode(&w, img)
if err != nil {
t.Fatalf("failed to encode valid image: %s", err)
t.Errorf("failed to encode valid image: %s", err)
continue
}
img1, err := Decode(&w)
if err != nil {
t.Fatalf("failed to decode roundtripped image: %s", err)
t.Errorf("failed to decode roundtripped image: %s", err)
continue
}
got := img1.Bounds()
want := img.Bounds()
if !got.Eq(want) {
t.Fatalf("roundtripped image bounds have changed, got: %s, want: %s", got, want)
t.Errorf("roundtripped image bounds have changed, got: %s, want: %s", got, want)
}
}
})