mirror of https://github.com/golang/go.git
doc/contribute.html: assorted fixes
0. windows uses all.bat instead of ./all.bash 1. correct expected all.bash output 2. mention you need to use an application specific password if you're using 2-step verification 3. note you can edit files included in CL by 'hg change NNNN' or 'hg file' R=golang-dev, adg, r CC=golang-dev https://golang.org/cl/6615060
This commit is contained in:
parent
b13c7eec64
commit
4c473c02e1
|
|
@ -46,24 +46,13 @@ tree to make sure the changes don't break other packages or programs:
|
||||||
|
|
||||||
<pre>
|
<pre>
|
||||||
cd $GOROOT/src
|
cd $GOROOT/src
|
||||||
./all.bash
|
./all.bash # On Windows, run all.bat
|
||||||
</pre>
|
</pre>
|
||||||
|
|
||||||
<p>
|
<p>
|
||||||
The final line printed by <code>make all</code> should be of the form:
|
After running for a while, the command should print "<code>ALL TESTS PASSED</code>".
|
||||||
</p>
|
</p>
|
||||||
|
|
||||||
<pre>
|
|
||||||
<i>N</i> known bugs; 0 unexpected bugs
|
|
||||||
</pre>
|
|
||||||
|
|
||||||
<p>
|
|
||||||
The value of <i>N</i> varies over time, but the line must
|
|
||||||
say “<code>0 unexpected bugs</code>” and must not
|
|
||||||
add “<code>test output differs</code>.”
|
|
||||||
</p>
|
|
||||||
|
|
||||||
|
|
||||||
<h2 id="Code_review">Code review</h2>
|
<h2 id="Code_review">Code review</h2>
|
||||||
|
|
||||||
<p>
|
<p>
|
||||||
|
|
@ -133,6 +122,8 @@ will be recorded in the <a href="http://code.google.com/p/go/source/list">Mercur
|
||||||
and in the <a href="/CONTRIBUTORS"><code>CONTRIBUTORS</code></a> file.
|
and in the <a href="/CONTRIBUTORS"><code>CONTRIBUTORS</code></a> file.
|
||||||
You can <a href="https://www.google.com/accounts/NewAccount">create a Google Account</a>
|
You can <a href="https://www.google.com/accounts/NewAccount">create a Google Account</a>
|
||||||
associated with any address where you receive email.
|
associated with any address where you receive email.
|
||||||
|
If you've enabled the two-step verification feature, don't forget to generate an
|
||||||
|
application-specific password and use that when prompted for a password.
|
||||||
</p>
|
</p>
|
||||||
|
|
||||||
<pre>
|
<pre>
|
||||||
|
|
@ -285,8 +276,10 @@ CL created: http://codereview.appspot.com/99999
|
||||||
</pre>
|
</pre>
|
||||||
|
|
||||||
<p>
|
<p>
|
||||||
If you need to re-edit the change description,
|
If you need to re-edit the change description, or change the files included in the CL,
|
||||||
run <code>hg change 99999</code>.
|
run <code>hg change 99999</code>. Alternatively, you can use <code>hg file 99999 somefile</code>
|
||||||
|
to add <code>somefile</code> to CL 99999, and use <code>hg file -d 99999 somefile</code> to remove
|
||||||
|
<code>somefile</code> from the CL.
|
||||||
</p>
|
</p>
|
||||||
|
|
||||||
<p>
|
<p>
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue