mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

strings: don't assert on Replace's allocs for ASAN 

CL 657935 caused failures on the ASAN builder.

Under ASAN, do not assert on the number of allocations incurred by
Replace.

Fixes #72973
This commit is contained in:
Julien Cretel 2025-03-20 19:45:01 +01:00
parent ba50de8429
commit 4aee3c2560
No known key found for this signature in database
GPG Key ID: 9BC102DCCA7031A9
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/strings/strings_test.go
View File

@ -7,6 +7,7 @@ package strings_test
import (
"bytes"
"fmt"
"internal/asan"
"io"
"iter"
"math"
@ -1473,9 +1474,11 @@ var ReplaceTests = []struct {
func TestReplace(t *testing.T) {
for _, tt := range ReplaceTests {
allocs := testing.AllocsPerRun(10, func() { Replace(tt.in, tt.old, tt.new, tt.n) })
if allocs > 1 {
t.Errorf("Replace(%q, %q, %q, %d) allocates %.2f objects", tt.in, tt.old, tt.new, tt.n, allocs)
if !asan.Enabled { // See issue #72973.
allocs := testing.AllocsPerRun(10, func() { Replace(tt.in, tt.old, tt.new, tt.n) })
if allocs > 1 {
t.Errorf("Replace(%q, %q, %q, %d) allocates %.2f objects", tt.in, tt.old, tt.new, tt.n, allocs)
}
}
if s := Replace(tt.in, tt.old, tt.new, tt.n); s != tt.out {
t.Errorf("Replace(%q, %q, %q, %d) = %q, want %q", tt.in, tt.old, tt.new, tt.n, s, tt.out)